From 15bd7fae0737155f33b2c56372c300ee0337b2b5 Mon Sep 17 00:00:00 2001 From: Maggie Neterval Date: Mon, 3 Jun 2019 16:50:15 -0400 Subject: [PATCH] fix(kubernetes): add cleaned up artifact manifests to output (#3711) --- .../KubernetesCleanupArtifactsOperation.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/clouddriver-kubernetes/src/main/groovy/com/netflix/spinnaker/clouddriver/kubernetes/v2/op/artifact/KubernetesCleanupArtifactsOperation.java b/clouddriver-kubernetes/src/main/groovy/com/netflix/spinnaker/clouddriver/kubernetes/v2/op/artifact/KubernetesCleanupArtifactsOperation.java index caefe77eda2..537a4abd028 100644 --- a/clouddriver-kubernetes/src/main/groovy/com/netflix/spinnaker/clouddriver/kubernetes/v2/op/artifact/KubernetesCleanupArtifactsOperation.java +++ b/clouddriver-kubernetes/src/main/groovy/com/netflix/spinnaker/clouddriver/kubernetes/v2/op/artifact/KubernetesCleanupArtifactsOperation.java @@ -26,6 +26,7 @@ import com.netflix.spinnaker.clouddriver.kubernetes.v2.description.manifest.KubernetesManifest; import com.netflix.spinnaker.clouddriver.kubernetes.v2.description.manifest.KubernetesManifestAnnotater; import com.netflix.spinnaker.clouddriver.kubernetes.v2.description.manifest.KubernetesManifestStrategy; +import com.netflix.spinnaker.clouddriver.kubernetes.v2.op.OperationResult; import com.netflix.spinnaker.clouddriver.kubernetes.v2.op.handler.KubernetesHandler; import com.netflix.spinnaker.clouddriver.kubernetes.v2.security.KubernetesV2Credentials; import com.netflix.spinnaker.clouddriver.model.ArtifactProvider; @@ -41,7 +42,7 @@ import org.apache.commons.lang.StringUtils; @Slf4j -public class KubernetesCleanupArtifactsOperation implements AtomicOperation { +public class KubernetesCleanupArtifactsOperation implements AtomicOperation { private final KubernetesCleanupArtifactsDescription description; private final KubernetesV2Credentials credentials; private final String accountName; @@ -65,7 +66,9 @@ private static Task getTask() { } @Override - public Void operate(List priorOutputs) { + public OperationResult operate(List priorOutputs) { + OperationResult result = new OperationResult(); + List artifacts = description.getManifests().stream() .map(this::artifactsToDelete) @@ -93,11 +96,12 @@ public Void operate(List priorOutputs) { if (StringUtils.isNotEmpty(a.getVersion())) { name = String.join("-", name, a.getVersion()); } - // todo add to outputs - handler.delete(credentials, a.getLocation(), name, null, new V1DeleteOptions()); + result.merge( + handler.delete(credentials, a.getLocation(), name, null, new V1DeleteOptions())); }); - return null; + result.setManifests(null); + return result; } private List artifactsToDelete(KubernetesManifest manifest) {