feat(aws/cloudformation): Add cloudformation controller #3279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API will be used by Orca to query the status of a cloudformation deploy operation asynchronously. It uses the cloud formation provider to access the cached value by the cloudformation caching agent. Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
changed the title
|
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side commit conventions here. |
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
force-pushed
the
cloudformation_controller
branch
from
c76d468 to
04c20e9
Compare
jervi
reviewed
Jan 17, 2019
| } catch (NoSuchElementException e) { | ||
| throw new ResourceNotFoundException("Cloud Formation stackId $stackId not found.") | ||
| } | ||
| log.debug("Cloud formation get stack with id $stackId"); |
There was a problem hiding this comment.
log.debug("Cloud formation get stack with id {}", stackId);
jervi
reviewed
Jan 17, 2019
| it.list(accountId, region) | ||
| }.flatten() | ||
| @RequestParam(required = false, defaultValue = "*") String region) { | ||
| log.debug("Cloud formation list stacks for account $accountId"); |
There was a problem hiding this comment.
log.debug("Cloud formation list stacks for account {}", accountId);
jervi
reviewed
Jan 17, 2019
| .filter(Optional::isPresent) | ||
| .map(Optional<CloudFormation>::get) | ||
| .findFirst() | ||
| .<ResourceNotFoundException>orElseThrow(() -> { |
There was a problem hiding this comment.
I don't think you need the generic stuff here, just do .orElseThrow(() -> {
There was a problem hiding this comment.
I think you can just do this? orElseThrow(() -> new ResourceNotFoundException("..."));
jervi
reviewed
Jan 17, 2019
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.data.rest.webmvc.ResourceNotFoundException; | ||
| import org.springframework.web.bind.annotation.*; |
There was a problem hiding this comment.
I'd split this into separate imports
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
pushed a commit
to xavileon/orca
that referenced
this pull request
Jan 17, 2019
This patch introduces the CloudFormation stage to deploy CloudFormation
templates. The stage basically consists of two main tasks:
1. an async task sent through `kato service` to clouddriver to deploy the
cloud formation template.
2. an task that waits for the completion of the deploy task by asking
cloud driver via its CloudFormation API.
The stage can be configured right now by specifying a json with the
following spec:
{
stackName: name of the stack to be deployed
region: region where the stack is to be deployed
template: cloud formation template json
parameters: json with the parameters that will be used by the template.
}
Related issue:
spinnaker/spinnaker#736
Related PRs:
spinnaker/clouddriver#3278
spinnaker/clouddriver#3279
spinnaker/clouddriver#3280
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
pushed a commit
to xavileon/orca
that referenced
this pull request
Jan 17, 2019
This patch introduces the CloudFormation stage to deploy CloudFormation
templates. The stage basically consists of two main tasks:
1. an async task sent through `kato service` to clouddriver to deploy the
cloud formation template.
2. an task that waits for the completion of the deploy task by asking
cloud driver via its CloudFormation API.
The stage can be configured right now by specifying a json with the
following spec:
```
{
stackName: name of the stack to be deployed
region: region where the stack is to be deployed
template: cloud formation template json
parameters: json with the parameters that will be used by the template.
}
```
Related issue:
spinnaker/spinnaker#736
Related PRs:
spinnaker/clouddriver#3278
spinnaker/clouddriver#3279
spinnaker/clouddriver#3280
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
changed the title
xavileon
pushed a commit
to xavileon/orca
that referenced
this pull request
Jan 17, 2019
This patch introduces the CloudFormation stage to deploy CloudFormation
templates. The stage basically consists of two main tasks:
1. an async task sent through `kato service` to clouddriver to deploy the
cloud formation template.
2. an task that waits for the completion of the deploy task by asking
cloud driver via its CloudFormation API.
The stage can be configured right now by specifying a json with the
following spec:
```
{
stackName: name of the stack to be deployed
region: region where the stack is to be deployed
template: cloud formation template json
parameters: json with the parameters that will be used by the template.
}
```
Related issue:
spinnaker/spinnaker#736
Related PRs:
spinnaker/clouddriver#3278
spinnaker/clouddriver#3279
spinnaker/clouddriver#3280
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
changed the title
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
robzienert
approved these changes
Jan 23, 2019
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
xavileon
pushed a commit
to xavileon/orca
that referenced
this pull request
Feb 11, 2019
This patch introduces the CloudFormation stage to deploy CloudFormation
templates. The stage basically consists of two main tasks:
1. an async task sent through `kato service` to clouddriver to deploy the
cloud formation template.
2. an task that waits for the completion of the deploy task by asking
cloud driver via its CloudFormation API.
The stage can be configured right now by specifying a json with the
following spec:
```
{
stackName: name of the stack to be deployed
region: region where the stack is to be deployed
template: cloud formation template json
parameters: json with the parameters that will be used by the template.
}
```
Related issue:
spinnaker/spinnaker#736
Related PRs:
spinnaker/clouddriver#3278
spinnaker/clouddriver#3279
spinnaker/clouddriver#3280
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
ajordens
pushed a commit
to spinnaker/orca
that referenced
this pull request
Feb 15, 2019
This patch introduces the CloudFormation stage to deploy CloudFormation
templates. The stage basically consists of two main tasks:
1. an async task sent through `kato service` to clouddriver to deploy the
cloud formation template.
2. an task that waits for the completion of the deploy task by asking
cloud driver via its CloudFormation API.
The stage can be configured right now by specifying a json with the
following spec:
```
{
stackName: name of the stack to be deployed
region: region where the stack is to be deployed
template: cloud formation template json
parameters: json with the parameters that will be used by the template.
}
```
Related issue:
spinnaker/spinnaker#736
Related PRs:
spinnaker/clouddriver#3278
spinnaker/clouddriver#3279
spinnaker/clouddriver#3280
Signed-off-by: Xavi León <xavi.leon@schibsted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API will be used by Orca to query the status of a cloudformation
deploy operation asynchronously. It uses the cloud formation provider
to access the cached value by the cloudformation caching agent.
This PR partly addresses spinnaker/spinnaker#736 and depends on #3278
Signed-off-by: Xavi León xavi.leon@schibsted.com