feat(aws): cache regions when parsing aws accounts #5532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To get around that, and to remove some of the redundancies from the process, we can cache the regions as we find them to reduce the number of such api calls. It also ends up showing improvements in the loading times as seen below:
For 436 aws accounts, with just the multi-threading changes, we saw that these accounts were loaded in 1m 3s. Now with caching enabled, and the same test setup, we see that these accounts are loaded in 35s, which is a 28s (44% improvement).
Changes: