From 4f07aeb1ac0550e5bf15c0a7402edb2ac9654701 Mon Sep 17 00:00:00 2001
From: Louis Jimenez <louisjimenez@google.com>
Date: Wed, 12 Jun 2019 13:49:20 -0400
Subject: [PATCH] fix(core): Make template table list scrollable (#7111)

https://github.com/spinnaker/spinnaker/issues/4519
---
 .../templates/v2/PipelineTemplatesV2.tsx      | 86 +++++++++----------
 .../search/infrastructure/infrastructure.less |  4 +
 2 files changed, 44 insertions(+), 46 deletions(-)

diff --git a/app/scripts/modules/core/src/pipeline/config/templates/v2/PipelineTemplatesV2.tsx b/app/scripts/modules/core/src/pipeline/config/templates/v2/PipelineTemplatesV2.tsx
index df98738103f..f77b10e50c0 100644
--- a/app/scripts/modules/core/src/pipeline/config/templates/v2/PipelineTemplatesV2.tsx
+++ b/app/scripts/modules/core/src/pipeline/config/templates/v2/PipelineTemplatesV2.tsx
@@ -169,57 +169,51 @@ export class PipelineTemplatesV2 extends React.Component<{}, IPipelineTemplatesV
               </h2>
             </div>
           </div>
-          <div className="infrastructure-section">
+          <div className="infrastructure-section container">
             {fetchError && (
-              <div className="container">
-                <PipelineTemplatesV2Error message={`There was an error fetching pipeline templates: ${fetchError}`} />
-              </div>
+              <PipelineTemplatesV2Error message={`There was an error fetching pipeline templates: ${fetchError}`} />
             )}
             {searchPerformed && !resultsAvailable && (
-              <div className="container">
-                <h4>No matches found for '{searchValue}'</h4>
-              </div>
+              <h4 className="infrastructure-section__message">No matches found for '{searchValue}'</h4>
             )}
             {resultsAvailable && (
-              <div className="container">
-                <table className="table">
-                  <thead>
-                    <tr>
-                      <th>Name</th>
-                      <th>Owner</th>
-                      <th>Updated</th>
-                      <th>Actions</th>
-                    </tr>
-                  </thead>
-                  <tbody>
-                    {filteredResults.map(template => {
-                      const { metadata } = template;
-                      const id = idForTemplate(template);
-                      return (
-                        <tr key={id}>
-                          <td>{metadata.name || '-'}</td>
-                          <td>{metadata.owner || '-'}</td>
-                          <td>{this.getUpdateTimeForTemplate(template) || '-'}</td>
-                          <td className="pipeline-template-actions">
-                            <UISref to={`.pipeline-templates-detail`} params={{ templateId: id }}>
-                              <button className="link">View</button>
-                            </UISref>
-                            <button className="link" onClick={() => this.setState({ deleteTemplateId: id })}>
-                              Delete
-                            </button>
-                            <button
-                              className="link link--create"
-                              onClick={() => this.handleCreatePipelineClick(template)}
-                            >
-                              Create Pipeline
-                            </button>
-                          </td>
-                        </tr>
-                      );
-                    })}
-                  </tbody>
-                </table>
-              </div>
+              <table className="table">
+                <thead>
+                  <tr>
+                    <th>Name</th>
+                    <th>Owner</th>
+                    <th>Updated</th>
+                    <th>Actions</th>
+                  </tr>
+                </thead>
+                <tbody>
+                  {filteredResults.map(template => {
+                    const { metadata } = template;
+                    const id = idForTemplate(template);
+                    return (
+                      <tr key={id}>
+                        <td>{metadata.name || '-'}</td>
+                        <td>{metadata.owner || '-'}</td>
+                        <td>{this.getUpdateTimeForTemplate(template) || '-'}</td>
+                        <td className="pipeline-template-actions">
+                          <UISref to={`.pipeline-templates-detail`} params={{ templateId: id }}>
+                            <button className="link">View</button>
+                          </UISref>
+                          <button className="link" onClick={() => this.setState({ deleteTemplateId: id })}>
+                            Delete
+                          </button>
+                          <button
+                            className="link link--create"
+                            onClick={() => this.handleCreatePipelineClick(template)}
+                          >
+                            Create Pipeline
+                          </button>
+                        </td>
+                      </tr>
+                    );
+                  })}
+                </tbody>
+              </table>
             )}
           </div>
         </div>
diff --git a/app/scripts/modules/core/src/search/infrastructure/infrastructure.less b/app/scripts/modules/core/src/search/infrastructure/infrastructure.less
index 5015b425ad9..f04d2b27552 100644
--- a/app/scripts/modules/core/src/search/infrastructure/infrastructure.less
+++ b/app/scripts/modules/core/src/search/infrastructure/infrastructure.less
@@ -6,6 +6,10 @@
   flex: 1 1 auto;
   height: 100%;
 
+  &-section__message {
+    text-align: center;
+  }
+
   .infrastructure-section.container {
     overflow-y: auto;
     overflow-x: hidden;