From 745f0a16ac689209ff44fe2bc6839317476034a6 Mon Sep 17 00:00:00 2001
From: Louis Jimenez <louisjimenez@google.com>
Date: Tue, 25 Jun 2019 10:24:52 -0400
Subject: [PATCH] fix(core): Display latest template in pipeline template list
 (#7145)

https://github.com/spinnaker/spinnaker/issues/4561
---
 app/scripts/modules/core/src/domain/IPipelineTemplateV2.ts   | 1 +
 .../src/pipeline/config/templates/PipelineTemplateReader.ts  | 5 ++++-
 .../config/templates/v2/pipelineTemplateV2.service.ts        | 1 +
 .../modules/core/src/pipeline/create/CreatePipelineModal.tsx | 4 +++-
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/app/scripts/modules/core/src/domain/IPipelineTemplateV2.ts b/app/scripts/modules/core/src/domain/IPipelineTemplateV2.ts
index 133e9d8c435..737000d0152 100644
--- a/app/scripts/modules/core/src/domain/IPipelineTemplateV2.ts
+++ b/app/scripts/modules/core/src/domain/IPipelineTemplateV2.ts
@@ -11,6 +11,7 @@ export interface IPipelineTemplateV2 {
   version?: string;
   updateTs?: string;
   digest?: string;
+  tag?: string;
 }
 
 interface IPipelineTemplateMetadataV2 {
diff --git a/app/scripts/modules/core/src/pipeline/config/templates/PipelineTemplateReader.ts b/app/scripts/modules/core/src/pipeline/config/templates/PipelineTemplateReader.ts
index 36214ae06e7..fa668a66557 100644
--- a/app/scripts/modules/core/src/pipeline/config/templates/PipelineTemplateReader.ts
+++ b/app/scripts/modules/core/src/pipeline/config/templates/PipelineTemplateReader.ts
@@ -146,7 +146,10 @@ export class PipelineTemplateReader {
     return API.one('pipelineTemplates')
       .get()
       .then((templates: IPipelineTemplateV2[]) => {
-        return templates.filter(({ schema }) => schema === 'v2');
+        return templates.filter(
+          ({ digest, schema, tag }) =>
+            schema === 'v2' && tag === PipelineTemplateV2Service.defaultTag && typeof digest === 'undefined',
+        );
       });
   }
 }
diff --git a/app/scripts/modules/core/src/pipeline/config/templates/v2/pipelineTemplateV2.service.ts b/app/scripts/modules/core/src/pipeline/config/templates/v2/pipelineTemplateV2.service.ts
index f9583445ead..27d2c74207a 100644
--- a/app/scripts/modules/core/src/pipeline/config/templates/v2/pipelineTemplateV2.service.ts
+++ b/app/scripts/modules/core/src/pipeline/config/templates/v2/pipelineTemplateV2.service.ts
@@ -77,6 +77,7 @@ export class PipelineTemplateV2Service {
   }
 
   private static schema = 'v2';
+  public static defaultTag = 'latest';
 
   public static inheritedKeys: Set<InheritedItem> = new Set([
     InheritedItem.Triggers,
diff --git a/app/scripts/modules/core/src/pipeline/create/CreatePipelineModal.tsx b/app/scripts/modules/core/src/pipeline/create/CreatePipelineModal.tsx
index a83694936a5..2dc42f047d3 100644
--- a/app/scripts/modules/core/src/pipeline/create/CreatePipelineModal.tsx
+++ b/app/scripts/modules/core/src/pipeline/create/CreatePipelineModal.tsx
@@ -166,7 +166,9 @@ export class CreatePipelineModal extends React.Component<ICreatePipelineModalPro
     const config = {
       ...pipelineConfig,
       ...(preselectedTemplate
-        ? PipelineTemplateV2Service.getPipelineTemplateConfigV2(preselectedTemplate.id)
+        ? PipelineTemplateV2Service.getPipelineTemplateConfigV2(
+            `${preselectedTemplate.id}:${PipelineTemplateV2Service.defaultTag}`,
+          )
         : PipelineTemplateReader.getPipelineTemplateConfig({
             name: command.name,
             application: application.name,