Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(core): add application-specific custom banners #6450
Jan 30, 2019
After talking to @ethanfrogers about this, a cool idea we came up with would be to have an emergency alert system. For example, PageDuty is alerting about a system being down, have that reflect in the Spinnaker UI for that application. I'd say this is more of a v2 or v3 feature for this, but figured I should bring it up
This looks really cool.
Could you also look at the application's attributes from Front50 to see if a banner is configured there? Not sure what the UI would look like, maybe another section on the config tab. But this would give application owners some control over the banners, and avoid having to redeploy Deck to make changes to banners.
Thanks all for the feedback! Adding links and automatic alert functionality sound like a good v2 for this -- hopefully we get some user feedback to inform what might be most helpful.
@anotherchrisberry I like the idea of moving the banner configuration out of settings and into an application's Front50 attributes -- I'll put some thought into the UI for this on the config tab and post another screenshot once I've updated this PR.
Just pushed an update to support configuring application banners from the Config tab -- let me know what you think of the UI. After some discussion here we decided it would be best to limit users to several Spinnaker color palette options for the banner text and background color.
@anotherchrisberry or @sbwsg this is an angular newb question -- is there a preferred method in Deck for communicating among components without a close ancestor, so that we can trigger an update in the header after a new banner config is enabled? Currently the user would need to refresh the page for an updated banner to take effect. Thanks!
Actually judging from what's there so far users will be able to submit app banner config as long as it's discoverable somehow. I think at the moment folks can inspect the traffic to see the payload sent but it might be worth documenting or adding a 'See application json' similarly to pipelines.