Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(help): Update help text for GitHub artifact URL #7588

Merged
merged 1 commit into from
Oct 31, 2019
Merged

chore(help): Update help text for GitHub artifact URL #7588

merged 1 commit into from
Oct 31, 2019

Conversation

justinrlee
Copy link
Contributor

No description provided.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@justinrlee
Copy link
Contributor Author

I think commits get squashed so I shouldn't have to actually update the commit title. Let me know if this isn't the case.

maggieneterval
maggieneterval approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Justin!

@maggieneterval maggieneterval merged commit df7120a into spinnaker:master Oct 31, 2019
erikmunson pushed a commit to erikmunson/deck that referenced this pull request Nov 6, 2019
chore(core): Bump version to 0.0.429
0cf5f75 
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover
88b8e6c feat(managed): add resource status indicator to security groups
f02b70d feat(managed): add managed resource data to security group groups
14283b2 feat(managed): add resource status indicator to load balancers
aaa349b feat(managed): add managed resource data to load balancer groups
a6d7756 feat(managed): add resource status indicator to clusters
8453260 feat(managed): add managed resource data to cluster groups
167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591)
a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests
90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests
7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook
b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585)
df7120a chore(help): Update help.contents.ts (spinnaker#7588)
98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583)
8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
@erikmunson erikmunson mentioned this pull request Nov 6, 2019
Merged
erikmunson pushed a commit that referenced this pull request Nov 6, 2019
chore(core): Bump version to 0.0.429 (#7596)
1108749 
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover
88b8e6c feat(managed): add resource status indicator to security groups
f02b70d feat(managed): add managed resource data to security group groups
14283b2 feat(managed): add resource status indicator to load balancers
aaa349b feat(managed): add managed resource data to load balancer groups
a6d7756 feat(managed): add resource status indicator to clusters
8453260 feat(managed): add managed resource data to cluster groups
167a151 feat(dataSources): add runtime error when defaultData isn't provided (#7591)
a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests
90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests
7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook
b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (#7585)
df7120a chore(help): Update help.contents.ts (#7588)
98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (#7583)
8d478a0 fix(helptext): clarify text for stage timeout (#7336)
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
@justinrlee
chore(help): Update help.contents.ts (spinnaker#7588)
385554d
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
chore(core): Bump version to 0.0.429 (spinnaker#7596)
9aa2039 
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover
88b8e6c feat(managed): add resource status indicator to security groups
f02b70d feat(managed): add managed resource data to security group groups
14283b2 feat(managed): add resource status indicator to load balancers
aaa349b feat(managed): add managed resource data to load balancer groups
a6d7756 feat(managed): add resource status indicator to clusters
8453260 feat(managed): add managed resource data to cluster groups
167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591)
a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests
90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests
7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook
b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585)
df7120a chore(help): Update help.contents.ts (spinnaker#7588)
98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583)
8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
sergiopena pushed a commit to sergiopena/deck that referenced this pull request Jan 10, 2020
@justinrlee @sergiopena
chore(help): Update help.contents.ts (spinnaker#7588)
e7c68df
sergiopena pushed a commit to sergiopena/deck that referenced this pull request Jan 10, 2020
@sergiopena
chore(core): Bump version to 0.0.429 (spinnaker#7596)
0b300a6 
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover
88b8e6c feat(managed): add resource status indicator to security groups
f02b70d feat(managed): add managed resource data to security group groups
14283b2 feat(managed): add resource status indicator to load balancers
aaa349b feat(managed): add managed resource data to load balancer groups
a6d7756 feat(managed): add resource status indicator to clusters
8453260 feat(managed): add managed resource data to cluster groups
167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591)
a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests
90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests
7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook
b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585)
df7120a chore(help): Update help.contents.ts (spinnaker#7588)
98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583)
8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@justinrlee @yunzhangit
chore(help): Update help.contents.ts (spinnaker#7588)
08566c8
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@yunzhangit
chore(core): Bump version to 0.0.429 (spinnaker#7596)
fa861f5 
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover
88b8e6c feat(managed): add resource status indicator to security groups
f02b70d feat(managed): add managed resource data to security group groups
14283b2 feat(managed): add resource status indicator to load balancers
aaa349b feat(managed): add managed resource data to load balancer groups
a6d7756 feat(managed): add resource status indicator to clusters
8453260 feat(managed): add managed resource data to cluster groups
167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591)
a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests
90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests
7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook
b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585)
df7120a chore(help): Update help.contents.ts (spinnaker#7588)
98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583)
8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggieneterval maggieneterval maggieneterval approved these changes

Assignees
No one assigned
Labels
target-release/1.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinrlee @spinnakerbot @maggieneterval