feat(dataSources): log runtime error when defaultData isn't provided #7591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What? Really? Do we know why this happens? I'd like this not to happen. |
erikmunson
pushed a commit
to erikmunson/deck
that referenced
this pull request
Nov 6, 2019
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover 88b8e6c feat(managed): add resource status indicator to security groups f02b70d feat(managed): add managed resource data to security group groups 14283b2 feat(managed): add resource status indicator to load balancers aaa349b feat(managed): add managed resource data to load balancer groups a6d7756 feat(managed): add resource status indicator to clusters 8453260 feat(managed): add managed resource data to cluster groups 167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591) a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests 90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests 7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585) df7120a chore(help): Update help.contents.ts (spinnaker#7588) 98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583) 8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
erikmunson
pushed a commit
that referenced
this pull request
Nov 6, 2019
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover 88b8e6c feat(managed): add resource status indicator to security groups f02b70d feat(managed): add managed resource data to security group groups 14283b2 feat(managed): add resource status indicator to load balancers aaa349b feat(managed): add managed resource data to load balancer groups a6d7756 feat(managed): add resource status indicator to clusters 8453260 feat(managed): add managed resource data to cluster groups 167a151 feat(dataSources): add runtime error when defaultData isn't provided (#7591) a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests 90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests 7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (#7585) df7120a chore(help): Update help.contents.ts (#7588) 98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (#7583) 8d478a0 fix(helptext): clarify text for stage timeout (#7336)
|
@christopherthielen yeah it's been that way forever, and not just limited to data sources. Anything that throws during app setup/bootstrapping has its exception tossed out and the 'Application not found' thing comes up. Just took a few mins to build out a 'Something went wrong' state and log actual exceptions: #7599 |
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover 88b8e6c feat(managed): add resource status indicator to security groups f02b70d feat(managed): add managed resource data to security group groups 14283b2 feat(managed): add resource status indicator to load balancers aaa349b feat(managed): add managed resource data to load balancer groups a6d7756 feat(managed): add resource status indicator to clusters 8453260 feat(managed): add managed resource data to cluster groups 167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591) a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests 90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests 7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585) df7120a chore(help): Update help.contents.ts (spinnaker#7588) 98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583) 8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover 88b8e6c feat(managed): add resource status indicator to security groups f02b70d feat(managed): add managed resource data to security group groups 14283b2 feat(managed): add resource status indicator to load balancers aaa349b feat(managed): add managed resource data to load balancer groups a6d7756 feat(managed): add resource status indicator to clusters 8453260 feat(managed): add managed resource data to cluster groups 167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591) a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests 90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests 7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585) df7120a chore(help): Update help.contents.ts (spinnaker#7588) 98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583) 8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
5acb0d0 feat(managed): Add status popovers, new props for HoverablePopover 88b8e6c feat(managed): add resource status indicator to security groups f02b70d feat(managed): add managed resource data to security group groups 14283b2 feat(managed): add resource status indicator to load balancers aaa349b feat(managed): add managed resource data to load balancer groups a6d7756 feat(managed): add resource status indicator to clusters 8453260 feat(managed): add managed resource data to cluster groups 167a151 feat(dataSources): add runtime error when defaultData isn't provided (spinnaker#7591) a10e068 feat(core/presentation): Reduce unnecessary renders in useLatestPromise, add tests 90b249d feat(core/presentation): Reduce unnecessary renders in useDebouncedValue, add tests 7ff7aa1 refactor(core/presentation): extract useIsMountedRef hook b18b577 chore(package): update to @types/enzyme@3.10.3, enzyme@3.10.0, enzyme-adapter-react-16@1.15.1 (spinnaker#7585) df7120a chore(help): Update help.contents.ts (spinnaker#7588) 98e8a4b fix(rerun): Hiding re-run as strategies should not be re-run (spinnaker#7583) 8d478a0 fix(helptext): clarify text for stage timeout (spinnaker#7336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a new required field and might unexpectedly mess up someone's custom data source in a non-obvious way, let's log an error with some context to make the resolution more obvious.
I originally wanted to just throw a full-on
Error, but those always get swallowed and end up making the application fail to load without showing up in the console.