From 61c1bbbd5297048e3fd4f5792f481c3798620f80 Mon Sep 17 00:00:00 2001 From: Nastya Smirnova Date: Sun, 7 Jul 2019 02:49:53 +0300 Subject: [PATCH] fix(bom): Fix generated pom.xml to omit invalid lombok declaration (#437) compileOnly dependency should not be added to generated pom.xml, see discussion: https://discuss.gradle.org/t/publishing-plugin-should-respect-compileonly-configuration/22903/2 see related commit: nebula-plugins/nebula-publishing-plugin@a5432aa --- build.gradle | 3 +++ fiat-bom/fiat-bom.gradle | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/build.gradle b/build.gradle index b3faef737..e9dc5fbf3 100644 --- a/build.gradle +++ b/build.gradle @@ -24,6 +24,9 @@ buildscript { classpath "com.netflix.spinnaker.gradle:spinnaker-dev-plugin:$spinnakerGradleVersion" if (Boolean.valueOf(enablePublishing)) { classpath "com.netflix.spinnaker.gradle:spinnaker-gradle-project:$spinnakerGradleVersion" +// TODO: nebula-publishing-plugin version override should be removed as soon as spinnaker-gradle-project is updated +// this override is needed to omit compileOnly dependencies from generated pom.xml + classpath "com.netflix.nebula:nebula-publishing-plugin:12.0.1" } } } diff --git a/fiat-bom/fiat-bom.gradle b/fiat-bom/fiat-bom.gradle index 2a7f3e020..2b1a9fdb2 100644 --- a/fiat-bom/fiat-bom.gradle +++ b/fiat-bom/fiat-bom.gradle @@ -17,11 +17,6 @@ apply plugin: "java-platform" apply plugin: "maven-publish" -// without this building the pom fails when using the Nebula publishing plugin -configurations { - create("compileOnly") -} - javaPlatform { allowDependencies() }