Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add endpoint for reordering pipelines #448

Merged
merged 1 commit into from Feb 14, 2019

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Feb 11, 2019

Adds /reorder endpoint for pipelines and pipeline strategies, so that these resources can be re-indexed with one request from Deck rather than one request per pipeline.

Corresponding PRs:
Deck: spinnaker/deck#6519
Gate: spinnaker/gate#723
Orca: spinnaker/orca#2663

Copy link
Contributor

@ajordens ajordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the direction.

Main motivation for splitting reorder out is to avoid potential confusion with the existing /pipelines/{application}/{strategy} endpoint.

@maggieneterval
Copy link
Contributor Author

Thanks so much for your help on this @ajordens and @anotherchrisberry -- should be ready for a second look. Adding @dibyom to double-check the Fiat logic as well.

Copy link
Contributor

@anotherchrisberry anotherchrisberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work!

@maggieneterval maggieneterval merged commit bcf8c54 into spinnaker:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants