fix(jobcontroller): correct API calls to clouddriver and remove invalid EP #764
Conversation
|
|
||
| @Headers("Accept: application/json") | ||
| @GET("/applications/{name}/jobs/{account}/{region}/{jobName}") | ||
| @POST("/applications/{name}/jobs/{account}/{region}/{jobName}") |
There was a problem hiding this comment.
Ideally, probably change clouddriver to be a get, but [orca already depends on this being POST](https://github.com/spinnaker/orca/blob/7c4896117fdcd6930cadaa82bfdf5dcb8383f89b/orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/KatoRestService.groovy#L47) and seems like not a great idea to make a breaking change like that
| @@ -29,14 +29,6 @@ class JobController { | |||
| @Autowired | |||
| JobService jobService | |||
|
|
|||
| @ApiOperation(value = "Get jobs", response = List.class) | |||
| @RequestMapping(value = "/applications/{applicationName}/jobs", method = RequestMethod.GET) | |||
| List getJobs(@PathVariable String applicationName, | |||
There was a problem hiding this comment.
i can't find this used anywhere... and even if it were, clouddriver doesn't have this EP... maybe i am misreading something, please correct me if I am wrong
There was a problem hiding this comment.
can we also do a quick check from the logs for the usage ?
There was a problem hiding this comment.
yup, didn't see anything in logs
|
LGTM |
…river
Currenty, calls to /applications/{app}/jobs/{account}/{region}/{name} (in `gate`) will fail
with an error from `clouddriver` that method is not supported because `gate` uses `GET` but
`POST` is expected on the `clouddriver` side
``/applications/{appName}/jobs` API is not used (as best as I can tell)
And even if it were used, it would fail because it calls to a non-existent
`clouddriver` API
marchello2000
force-pushed
the
mark/fixgetjobep
branch
from
0f8fcae
to
5f723cd
Compare
fix(jobcontroller): getJobDetails must use a POST not a GET to clouddriver
Currenty, calls to /applications/{app}/jobs/{account}/{region}/{name} (in
gate) will failwith an error from
clouddriverthat method is not supported becausegateusesGETbutPOSTis expected on theclouddriversidefix(jobcontroller): remove un-used, non-existent API
``/applications/{appName}/jobs
API is not used (as best as I can tell) And even if it were used, it would fail because it calls to a non-existentclouddriver` API