New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy): Add default AWS settings to deck #1024

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@mizzy
Contributor

mizzy commented Aug 29, 2018

Current halconfig/settings.js has fixed values for aws settings.
It should pick up settings configured by halyard.

This works with spinnaker/deck#5681 .

Ref: spinnaker/spinnaker#3271

@lwander

Nice!

@lwander lwander merged commit 8376dfa into spinnaker:master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mizzy

This comment has been minimized.

Contributor

mizzy commented Aug 29, 2018

Thanks for merging!

@mizzy mizzy deleted the mizzy:aws-settings-to-deck branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment