Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(halyard): Use "kubectl replace --force" for Kubernetes Secret creation #1272

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@legal90
Copy link
Contributor

commented Apr 12, 2019

This PR fixes the issue of deploying Spinnaker in Kubernetes when the halconfig is quite big (~35 accounts and more):
https://community.spinnaker.io/t/halyard-with-v2-metadata-annotations-too-long/894

Unlikely, kubectl apply, the kubectl replace --force command does not preserves
current data to the annotation. That allows to work around the issue when the halyard config is quite big and could not fit into the annotation.

@legal90 legal90 force-pushed the volvo-cars:kubectl-replace branch from 1f6d3f0 to 1dec463 Apr 12, 2019

fix(halyard): Use "kubectl replace --force" for Kubernetes Secret cre…
…ation

Unlikely, "kubectl apply", "kubectl replace --force" command does not preserves
current data to the annotation. That allows to work around the issue when the
halyard config is quite big and could not fit into the annotation.

@legal90 legal90 force-pushed the volvo-cars:kubectl-replace branch from 1dec463 to 4cde13d Apr 12, 2019

@ezimanyi
Copy link
Member

left a comment

This seems like a reasonable change to me. Ideally we'd move away from needing such large configmaps/secrets (as there is still the size limit of the secret) but for now this should at least raise the limit.

@maggieneterval does this seem reasonable to you?

@maggieneterval

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@ezimanyi seems like an okay workaround to me, as long as there's no apply-specific functionality we're relying on for secret creation?

@ezimanyi

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

I dug around a bit, and didn't see any apply-specific things we're relying on for secrets.

@maggieneterval maggieneterval self-requested a review Apr 15, 2019

@ezimanyi ezimanyi merged commit 17d18c1 into spinnaker:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@legal90 legal90 deleted the volvo-cars:kubectl-replace branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.