Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider/kubernetes): use the right URL to download heptio #986

Merged
1 commit merged into from Jul 20, 2018
Merged

fix(provider/kubernetes): use the right URL to download heptio #986

1 commit merged into from Jul 20, 2018

Conversation

danmaas
Copy link
Contributor

@danmaas danmaas commented Jul 18, 2018

Hi - the Dockerfiles seem have a typo in the URL that is used to download the heptio-authenticator-aws binary.

Currently, the URL resolves to
https://amazon-eks.s3-us-west-2.amazonaws.com/v1.10.3/2018-06-05/bin/linux/amd64/heptio-authenticator-aws
which returns a "NoSuchKey" error and dumps a non-working file into the Docker image at /usr/local/bin/heptio-authenticator-aws

The correct URL should be
https://amazon-eks.s3-us-west-2.amazonaws.com/1.10.3/2018-06-05/bin/linux/amd64/heptio-authenticator-aws

The difference is that the "v" in front of the Kubectl version number must be dropped from this URL.

@anshrma
Copy link
Contributor

anshrma commented Jul 18, 2018

@lwander - your thoughts on this one as well please.

@anshrma
Copy link
Contributor

anshrma commented Jul 20, 2018

@spinnaker/google-reviewers - thoughts on above please ?

@ghost ghost merged commit ce91cb7 into spinnaker:master Jul 20, 2018
@danmaas danmaas deleted the heptio-url-fix branch July 20, 2018 20:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants