Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider/kubernetes): use the right URL to download heptio #986

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
None yet
4 participants
@danmaas
Copy link
Contributor

danmaas commented Jul 18, 2018

Hi - the Dockerfiles seem have a typo in the URL that is used to download the heptio-authenticator-aws binary.

Currently, the URL resolves to
https://amazon-eks.s3-us-west-2.amazonaws.com/v1.10.3/2018-06-05/bin/linux/amd64/heptio-authenticator-aws
which returns a "NoSuchKey" error and dumps a non-working file into the Docker image at /usr/local/bin/heptio-authenticator-aws

The correct URL should be
https://amazon-eks.s3-us-west-2.amazonaws.com/1.10.3/2018-06-05/bin/linux/amd64/heptio-authenticator-aws

The difference is that the "v" in front of the Kubectl version number must be dropped from this URL.

@anshrma

This comment has been minimized.

Copy link
Contributor

anshrma commented Jul 18, 2018

@lwander - your thoughts on this one as well please.

@anshrma

This comment has been minimized.

Copy link
Contributor

anshrma commented Jul 20, 2018

@spinnaker/google-reviewers - thoughts on above please ?

@sbwsg

sbwsg approved these changes Jul 20, 2018

@sbwsg sbwsg merged commit ce91cb7 into spinnaker:master Jul 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danmaas danmaas deleted the maasdigital:heptio-url-fix branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.