diff --git a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/Transforms.scala b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/Transforms.scala index f28629fd2..f7e0eadbf 100644 --- a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/Transforms.scala +++ b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/Transforms.scala @@ -16,7 +16,7 @@ package com.netflix.kayenta.judge -import com.netflix.kayenta.judge.detectors.OutlierDetector +import com.netflix.kayenta.judge.detectors.BaseOutlierDetector object Transforms { @@ -53,7 +53,7 @@ object Transforms { * @param data * @param detector */ - def removeOutliers(data: Array[Double], detector: OutlierDetector): Array[Double] ={ + def removeOutliers(data: Array[Double], detector: BaseOutlierDetector): Array[Double] ={ val outliers = detector.detect(data) data.zip(outliers).collect{case (v, false) => v} } @@ -64,7 +64,7 @@ object Transforms { * @param detector * @return */ - def removeOutliers(metric: Metric, detector: OutlierDetector): Metric = { + def removeOutliers(metric: Metric, detector: BaseOutlierDetector): Metric = { metric.copy(values = removeOutliers(metric.values, detector)) } diff --git a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/OutlierDetector.scala b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/BaseOutlierDetector.scala similarity index 95% rename from kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/OutlierDetector.scala rename to kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/BaseOutlierDetector.scala index 85b39f147..abb34c297 100644 --- a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/OutlierDetector.scala +++ b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/BaseOutlierDetector.scala @@ -16,7 +16,7 @@ package com.netflix.kayenta.judge.detectors -abstract class OutlierDetector{ +abstract class BaseOutlierDetector{ /** * Determine which data points are outliers diff --git a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/IQRDetector.scala b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/IQRDetector.scala index 261d73acc..467a23c2c 100644 --- a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/IQRDetector.scala +++ b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/IQRDetector.scala @@ -28,7 +28,7 @@ import com.netflix.kayenta.judge.stats.DescriptiveStatistics.percentile * Reference: https://en.wikipedia.org/wiki/Outlier#Tukey.27s_test * Note: To reduce sensitivity, take the max of the IQR or the 99th percentile */ -class IQRDetector(factor: Double = 1.5, reduceSensitivity: Boolean = false) extends OutlierDetector { +class IQRDetector(factor: Double = 1.5, reduceSensitivity: Boolean = false) extends BaseOutlierDetector { require(factor > 0.0, "factor must be greater than zero") diff --git a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/KSigmaDetector.scala b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/KSigmaDetector.scala index 8dd3caa6a..37dba0c9c 100644 --- a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/KSigmaDetector.scala +++ b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/detectors/KSigmaDetector.scala @@ -24,7 +24,7 @@ import org.apache.commons.math3.stat.StatUtils * Values which are greater than or less than k standard deviations from the mean are considered outliers * Reference: https://en.wikipedia.org/wiki/68%E2%80%9395%E2%80%9399.7_rule */ -class KSigmaDetector(k: Double = 3.0) extends OutlierDetector{ +class KSigmaDetector(k: Double = 3.0) extends BaseOutlierDetector{ require(k > 0.0, "k must be greater than zero")