From 4b80f7a0a48581fae31735092441c61d0f116c7a Mon Sep 17 00:00:00 2001 From: Matt Duftler Date: Mon, 6 Mar 2017 09:22:27 -0500 Subject: [PATCH] fix(core): Avoid capturing security group ingress rules with empty cidr's. (#1206) --- .../tasks/providers/gce/GoogleSecurityGroupUpserter.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/providers/gce/GoogleSecurityGroupUpserter.groovy b/orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/providers/gce/GoogleSecurityGroupUpserter.groovy index 137d817f59..82f38ca453 100644 --- a/orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/providers/gce/GoogleSecurityGroupUpserter.groovy +++ b/orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/tasks/providers/gce/GoogleSecurityGroupUpserter.groovy @@ -67,7 +67,7 @@ class GoogleSecurityGroupUpserter implements SecurityGroupUpserter, CloudProvide // What is currently cached? Set existingSourceRanges = existingSecurityGroup.inboundRules.findResults { inboundRule -> - inboundRule.range ? inboundRule.range.ip + inboundRule.range.cidr : null + inboundRule.range?.ip ? inboundRule.range.ip + inboundRule.range.cidr : null }.unique() as Set boolean rangesMatch = existingSourceRanges == targetSecurityGroupSourceRanges