feat(monitoredDeploy): Completed event should include details of success/failure #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
reviewed
Oct 6, 2019
...ix/spinnaker/orca/clouddriver/pipeline/servergroup/strategies/MonitoredDeployStrategy.groovy
Outdated
Show resolved
Hide resolved
.../com/netflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTask.java
Outdated
Show resolved
Hide resolved
gal-yardeni
changed the title
...ix/spinnaker/orca/clouddriver/pipeline/servergroup/strategies/MonitoredDeployStrategy.groovy
Outdated
Show resolved
Hide resolved
...oovy/com/netflix/spinnaker/orca/clouddriver/tasks/cluster/ClusterSizePreconditionTask.groovy
Outdated
Show resolved
Hide resolved
...ntmonitor/src/main/java/com/netflix/spinnaker/orca/deploymentmonitor/models/RequestBase.java
Outdated
Show resolved
Hide resolved
|
Once I merge the rollback pr #3222 you can add the failure/rollback flag |
.../com/netflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTask.java
Outdated
Show resolved
Hide resolved
gal-yardeni
force-pushed
the
complete-event-status
branch
from
e472453
to
2081651
Compare
orca-core/src/main/java/com/netflix/spinnaker/orca/pipeline/model/Stage.java
Outdated
Show resolved
Hide resolved
...va/com/netflix/spinnaker/orca/deploymentmonitor/models/MonitoredDeployInternalStageData.java
Outdated
Show resolved
Hide resolved
.../com/netflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTask.java
Outdated
Show resolved
Hide resolved
orca-core/src/main/java/com/netflix/spinnaker/orca/pipeline/model/Stage.java
Outdated
Show resolved
Hide resolved
...ix/spinnaker/orca/clouddriver/pipeline/servergroup/strategies/MonitoredDeployStrategy.groovy
Outdated
Show resolved
Hide resolved
marchello2000
requested changes
Oct 22, 2019
gal-yardeni
changed the title
...etflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTaskSpec.groovy
Outdated
Show resolved
Hide resolved
...etflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTaskSpec.groovy
Outdated
Show resolved
Hide resolved
.../com/netflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTask.java
Outdated
Show resolved
Hide resolved
.../com/netflix/spinnaker/orca/clouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTask.java
Outdated
Show resolved
Hide resolved
…ouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTaskSpec.groovy Co-Authored-By: Mark Vulfson <markvu@live.com>
…ouddriver/tasks/monitoreddeploy/NotifyDeployCompletedTask.java Co-Authored-By: Mark Vulfson <markvu@live.com>
| return TaskResult.ofStatus(ExecutionStatus.SUCCEEDED); | ||
| } | ||
|
|
||
| private DeploymentCompletedRequest.DeploymentStatus convertStageStatus(Boolean failedStatus) { |
There was a problem hiding this comment.
nit: you can make this boolean now
Suggested change
| private DeploymentCompletedRequest.DeploymentStatus convertStageStatus(Boolean failedStatus) { | |
| private DeploymentCompletedRequest.DeploymentStatus convertStageStatus(boolean failedStatus) { |
marchello2000
approved these changes
Oct 28, 2019
This was referenced Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed event (see NotifyDeployCompletedTask in orca) should populate the status and rollback fields of the DeploymentCompletedRequest.
Example:
deploymentStatus: “success” / ”failure”,
rollback: "failure" / "success" / "not_performed"