From 357c1aecb56762c8526593950a51c23f68db832f Mon Sep 17 00:00:00 2001 From: Ethan Rogers Date: Mon, 7 Oct 2019 10:25:20 -0700 Subject: [PATCH] fix(bakeManifest): revert to set-string (#439) reverts a change introduced in #418 where we went from using `--set-string` to `--set`. This change caused backwards incompaitble changes because the parser for `--set` in helm coerces integers into floats when it injects them into templates. `--set-string` was introduced to fix this in helm 2. --- .../spinnaker/rosco/manifests/helm/HelmTemplateUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rosco-manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/helm/HelmTemplateUtils.java b/rosco-manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/helm/HelmTemplateUtils.java index 71ac6d5ce..323501d8f 100644 --- a/rosco-manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/helm/HelmTemplateUtils.java +++ b/rosco-manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/helm/HelmTemplateUtils.java @@ -71,7 +71,7 @@ public BakeRecipe buildBakeRecipe(BakeManifestEnvironment env, HelmBakeManifestR for (Map.Entry entry : overrides.entrySet()) { overrideList.add(entry.getKey() + "=" + entry.getValue().toString()); } - command.add("--set"); + command.add("--set-string"); command.add(overrideList.stream().collect(Collectors.joining(","))); }