Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bakery/oracle): private key passphrase is optional #302

Merged
merged 2 commits into from Nov 8, 2018

Conversation

guoyongzhang
Copy link
Contributor

packer variable oracle_pass_phrase should be optional, not required.

Copy link

@shihchang shihchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guoyongzhang
Copy link
Contributor Author

Please review and merge. Thanks.

@guoyongzhang
Copy link
Contributor Author

Someone with write access please review and merge this PR please.

@ezimanyi ezimanyi merged commit 8edec78 into spinnaker:master Nov 8, 2018
@guoyongzhang guoyongzhang deleted the oracle_bakery branch November 8, 2018 15:55
clanesf pushed a commit to clanesf/rosco that referenced this pull request Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants