Support for baking helm charts from git/repo artifacts #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 29, 2020 15:38
…akeManifestEnvironment to pave the way for helm to use git/repo artifacts
dbyron0
changed the title
|
cc: @ethanfrogers |
ezimanyi
reviewed
Nov 2, 2020
|
|
||
| verify(helmConfigurationProperties, atMost(1)).getV2ExecutablePath(); | ||
| verify(helmConfigurationProperties, atMost(1)).getV3ExecutablePath(); | ||
| verifyNoMoreInteractions(helmConfigurationProperties); |
There was a problem hiding this comment.
Looks like these verifications are originally from the Groovy test so not new...but would it make sense to just drop these three verify* assertions and only do the below assertEquals?
It feels like verifying the interactions like this is over-specifying...the consumer shouldn't care what methods get called as long as the command is right.
...anifests/src/test/java/com/netflix/spinnaker/rosco/manifests/helm/HelmTemplateUtilsTest.java
Outdated
Show resolved
Hide resolved
...ifests/src/main/java/com/netflix/spinnaker/rosco/manifests/helm/HelmBakeManifestRequest.java
Outdated
Show resolved
Hide resolved
...o-manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/BakeManifestEnvironment.java
Outdated
Show resolved
Hide resolved
...anifests/src/test/java/com/netflix/spinnaker/rosco/manifests/helm/HelmTemplateUtilsTest.java
Show resolved
Hide resolved
…fests/helm/HelmBakeManifestRequest.java Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
…lByDefault at the class level
ezimanyi
approved these changes
Nov 2, 2020
mergify bot
pushed a commit
to spinnaker/deck
that referenced
this pull request
Nov 20, 2020
…oose when baking helm charts (#8743) now that spinnaker/rosco#740 is in Co-authored-by: David Byron <david.byron@avast.com>
rumit-opsmx
pushed a commit
to rumit-opsmx/deck
that referenced
this pull request
Nov 30, 2020
* feat(aws): added the ability to modify CPU credits (spinnaker#8736) * feat(aws): added the ability to modify cpu credits - added a toggle for cpu credits with help fields - added reusable component for a toggle - added the ability to display toggle and reset conditionally - display cpu credits correctly in 'clone' wizard spinnaker/spinnaker#5989 * Addressed PR feedback - added a separate setting for cpu credits - converted class components to functional components - other misc. feedback * PR feedback: added React hooks * Removed unused component * feat(bake): include git/repo artifacts in the list of artifacts to choose when baking helm charts (spinnaker#8743) now that spinnaker/rosco#740 is in Co-authored-by: David Byron <david.byron@avast.com> * fix(titus): Fallback dimensions for target tracking policy (spinnaker#8746) * fix(titus): Disable edits of step scaling dimensions (spinnaker#8747) * feat(core): Add a container for migration banners (spinnaker#8735) * feat(core): Add migrations container component * feat(core): Add container to routes eligible for migrations feat(core): Add container to routes eligible for migrations feat(core): Edit migration config type feat(core): Edit migration config type feat(core): Edit migration config type fix(core): Update css * Refactor and rename Delete test banner Delete test banner * Update app/scripts/modules/core/src/banner/BannerContainer.tsx * chore(core): Upload new illustrations (spinnaker#8744) * feat(core/managed): surface pre-deployment steps for versions (spinnaker#8750) * feat(core/presentation): add bake icon * feat(core/domain): add lifecycle steps to managed artifact versions * feat(core/managed): show status bubble for baking on versions * feat(core/managed): surface baking on version detail pane Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * chore(amazon): publish amazon@0.0.282 2ec9db0 fix(titus): Disable edits of step scaling dimensions (spinnaker#8747) 7a8f939 feat(aws): added the ability to modify CPU credits (spinnaker#8736) * chore(core): publish core@0.0.533 f4d7d14 feat(core/managed): surface pre-deployment steps for versions (spinnaker#8750) 0cdf836 chore(core): Upload new illustrations (spinnaker#8744) e3c80c3 feat(core): Add a container for migration banners (spinnaker#8735) 976e958 feat(bake): include git/repo artifacts in the list of artifacts to choose when baking helm charts (spinnaker#8743) 7a8f939 feat(aws): added the ability to modify CPU credits (spinnaker#8736) * chore(titus): publish titus@0.0.155 2ec9db0 fix(titus): Disable edits of step scaling dimensions (spinnaker#8747) fadab40 fix(titus): Fallback dimensions for target tracking policy (spinnaker#8746) * fix(core): Fix details drawer positioning (spinnaker#8754) * chore(core): Export all generic instance components (spinnaker#8755) * chore(core): publish core@0.0.534 f102966 chore(core): Export all generic instance components (spinnaker#8755) 530f59c fix(core): Fix details drawer positioning (spinnaker#8754) * chore(pluginsdk-peerdeps): Publish 0.0.4 (spinnaker#8757) Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> Co-authored-by: David Byron <dbyron@dbyron.com> Co-authored-by: David Byron <david.byron@avast.com> Co-authored-by: Alan Quach <aquach@netflix.com> Co-authored-by: caseyhebebrand <caseyhebebrand@gmail.com> Co-authored-by: Erik Munson <emunson@netflix.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: chebebrand <chebebrand@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a crack at addressing spinnaker/spinnaker#5249, with some groovy --> java test cleanups along the way.
There are likely some corresponding UI changes that I could use a hand with.