Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy artifacts stored in private Github Enterprise #2693

Closed
eboumendil opened this issue Apr 23, 2018 · 2 comments

Comments

@eboumendil
Copy link

commented Apr 23, 2018

Cloud Provider : Kubernetes V2

Feature Area : Artifact deployment from a private Github Enterprise

Description

I am trying to deploy artifacts using a private Github Enterprise setup. Looking at https://github.com/spinnaker/clouddriver/blob/master/clouddriver-artifacts/src/main/java/com/netflix/spinnaker/clouddriver/artifacts/github/GitHubArtifactAccount.java, it seems I cannot specify an alternative base URL to point to my private Github Enterprise endpoint.

Steps to Reproduce

Deploy an artifact from a private Github Enterprise.

@wjoel

This comment has been minimized.

Copy link

commented Apr 24, 2018

The URL to your private GitHub Enterprise endpoint is included in the webhook messages that trigger your pipelines, and/or specified in the artifacts themselves (eg. in the case of default artifacts).

You shouldn't need to specify it in any config.

@lwander

This comment has been minimized.

Copy link
Member

commented Apr 24, 2018

That's right, the reference field should link to the content URL for your GHE domain. There is an example here: https://www.spinnaker.io/reference/artifacts/types/github-file/#fields

@lwander lwander closed this Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.