New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS settings configured by halyard to be picked up in settings.js #3271

Open
mizzy opened this Issue Aug 29, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@mizzy

mizzy commented Aug 29, 2018

Issue Summary:

Current halconfig/settings.js has fixed values for aws settings.
It should pick up settings configured by halyard.

Cloud Provider(s):

aws

Environment:

Feature Area:

Halyard/Deck

Description:

Current halconfig/settings.js has fixed values for aws config like this:

    aws: {
      defaults: {
        account: 'test',
        region: 'us-east-1',
        iamRole: 'BaseIAMRole',
      },
      defaultSecurityGroups: [],
      loadBalancers: {
        // if true, VPC load balancers will be created as internal load balancers if the selected subnet has a purpose
        // tag that starts with "internal"
        inferInternalFlagFromSubnet: false,
      },
      useAmiBlockDeviceMappings: false,
    },

I think it should pick up settings configured by halyard like other provider settings.

Steps to Reproduce:

Additional Details:

I'm trying Spinnaker in ap-northeast-1 region. But settings.js deployed by halyard has us-east-1 setting. Deck does not work well because of this mismatch. So I think settings.js should pick up
AWS settings configured by halyard like other provider settings.

I've written code to solve this issue.

mizzy/halyard@984b8cc
mizzy/deck@b0b6c7c

@lwander

This comment has been minimized.

Member

lwander commented Aug 29, 2018

Nice work! Can you open PRs for your fixes?

@mizzy

This comment has been minimized.

mizzy commented Aug 29, 2018

I will open PRs soon.

@slupers

This comment has been minimized.

slupers commented Sep 6, 2018

We've run into this issue as well and used overrides in settings-local.js as a workaround. Thank you for the fixes, @mizzy !
If we have several AWS accounts configured with hal, do we need to set some kind of configuration in spinnaker-local.yml or clouddriver-local.yml or such? In other words, do we need to set something like this:

aws:
  defaults:
    account: AWS_ACCOUNT_NAME
    region: AWS_REGION_NAME
  primaryAccount: AWS_ACCOUNT_NAME
@spinnakerbot

This comment has been minimized.

spinnakerbot commented Oct 21, 2018

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@spinnakerbot spinnakerbot added the stale label Oct 21, 2018

@spinnakerbot

This comment has been minimized.

spinnakerbot commented Dec 5, 2018

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment