New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal --version on debian install returns "Unknown" #3720

Closed
tillig opened this Issue Dec 12, 2018 · 11 comments

Comments

Projects
None yet
10 participants
@tillig
Copy link

tillig commented Dec 12, 2018

Issue Summary:

Installing Halyard on Ubuntu 18.04 using the instructions in the documentation (debian/InstallHalyard.sh) results in hal --version yielding Unknown instead of a real version.

Cloud Provider(s):

Azure

Environment:

Tried in two environments:

  • Windows Subsystem for Linux (Ubuntu 18.04)
  • VirtualBox VM running Ubuntu 18.04

Steps to Reproduce:

Start with a machine that doesn't have Halyard.

  • Get the installer script and run it as outlined in the documentation.
  • At the end of the install, after starting the Halyard daemon, you see the version Unknown.
  • Run hal --version and get Unknown.

Additional Details:

This seems to have shown up as of 1.13. I did try installing using the stable/InstallHalyard.sh rather than debian/InstallHalyard.sh and while that does yield a version at the end of the install... the Halyard daemon doesn't reliably run. Most commands result in a notice that the Halyard daemon isn't running, but there's also no service registered with the daemon.

@tillig tillig changed the title hal --version on debian install returns hal --version on debian install returns "Unknown" Dec 12, 2018

@tillig

This comment has been minimized.

Copy link
Author

tillig commented Dec 12, 2018

Here's a Vagrantfile that can reproduce the issue using a Vagrant VM. I'm using the Hyper-V provider at the moment, but I don't think that matters. Once you have the machine provisioned you can vagrant ssh into it and do a hal --version to get the Unknown.

@abergmeier

This comment has been minimized.

Copy link

abergmeier commented Dec 14, 2018

Same for 16.04.

@mononokehime

This comment has been minimized.

Copy link

mononokehime commented Dec 17, 2018

Same for me on Ubuntu 16.04 with a fresh install. Along with the redis bug #3594

@michaelsorenson

This comment has been minimized.

Copy link

michaelsorenson commented Dec 18, 2018

I got this on Ubuntu 14.04 and 16.04 with a fresh install

@ericjee

This comment has been minimized.

Copy link

ericjee commented Dec 20, 2018

Got the same Unknown returns after upgraded with sudo update-halyard, Mine was macos

@rthuffman

This comment has been minimized.

Copy link

rthuffman commented Jan 9, 2019

Was getting this same error, ran sudo update-halyard today and the error persists.

@kaitea

This comment has been minimized.

Copy link

kaitea commented Jan 12, 2019

Got the same Unknown error with fresh install on macOS Mojave

@schefs

This comment has been minimized.

Copy link

schefs commented Jan 14, 2019

same error in a docker image gcr.io/spinnaker-marketplace/halyard:stable

@ttomsu

This comment has been minimized.

Copy link
Contributor

ttomsu commented Jan 15, 2019

The Halyard distribution seems to be borked.

Using sudo bash InstallHalyard.sh --version 1.12.0 yields:

ttomsu@deleteme2:/opt/halyard/lib$ ls -al halyard*
-rw-r--r-- 1 root root  20836 Oct 24 15:39 halyard-backup-1.12.0-20181024113436.jar
-rw-r--r-- 1 root root 663446 Oct 24 15:39 halyard-cli-1.12.0-20181024113436.jar
-rw-r--r-- 1 root root 575807 Oct 24 15:39 halyard-config-1.12.0-20181024113436.jar
-rw-r--r-- 1 root root 123557 Oct 24 15:39 halyard-core-1.12.0-20181024113436.jar
-rw-r--r-- 1 root root 815191 Oct 24 15:39 halyard-deploy-1.12.0-20181024113436.jar
-rw-r--r-- 1 root root  24266 Oct 24 15:39 halyard-proto-1.12.0-20181024113436.jar
-rw-r--r-- 1 root root  99921 Oct 24 15:39 halyard-web-1.12.0-20181024113436.jar

and

ttomsu@deleteme2:~$ unzip -p /opt/halyard/lib/halyard-cli-1.12.0-20181024113436.jar META-INF/MANIFEST.MF
Manifest-Version: 1.0
Implementation-Title: com.netflix.spinnaker.halyard#halyard-cli;1.12.0
 -20181024113436
Module-Origin: https://github.com/spinnaker/halyard
Build-Date: 2018-10-24_11:39:00
Build-Id: 292
Implementation-Version: 1.12.0-20181024113436
Module-Owner: netflixoss@netflix.com
Build-Number: 292
Built-By: jenkins
Change: ac8097e
Module-Source: /halyard-cli
Branch: master
Built-Status: integration
Gradle-Version: 3.5
Build-Job: Build_Halyard
Built-OS: Linux
X-Compile-Target-JDK: 1.8
Build-Host: http://localhost:4040/
X-Compile-Source-JDK: 1.8
Created-By: 1.8.0_181-8u181-b13-0ubuntu0.18.04.1-b13 (Oracle Corporati
 on)
Module-Email: netflixoss@netflix.com
Build-Java-Version: 1.8.0_181

hal -v is displaying the value in this file's Implementation-Version field.

With stable (i.e. 1.13.0 AFAICT) the version is completely missing:

ttomsu@deleteme2:/opt/halyard/lib$ ls -al halyard-*
-rw-r--r-- 1 root root  19924 Dec 11 07:11 halyard-backup.jar
-rw-r--r-- 1 root root 678528 Dec 11 07:11 halyard-cli.jar
-rw-r--r-- 1 root root 575791 Dec 11 07:11 halyard-config.jar
-rw-r--r-- 1 root root 122676 Dec 11 07:11 halyard-core.jar
-rw-r--r-- 1 root root 820065 Dec 11 07:11 halyard-deploy.jar
-rw-r--r-- 1 root root  23358 Dec 11 07:11 halyard-proto.jar
-rw-r--r-- 1 root root 101174 Dec 11 07:11 halyard-web.jar
@ttomsu

This comment has been minimized.

Copy link
Contributor

ttomsu commented Jan 15, 2019

Now that Bintray is back up, I've verified that the nightly build has the versions back:

ttomsu@deleteme2:~$ hal -v
1.14.0-20190115145153

I'll work on getting 1.13.0 patched to 1.13.1

@ttomsu ttomsu self-assigned this Jan 15, 2019

@ttomsu

This comment has been minimized.

Copy link
Contributor

ttomsu commented Jan 15, 2019

I was able to successfully sudo bash InstallHalyard to the stable version (1.13.1):

ttomsu@deleteme2:~$ hal -v
1.13.1-20190115161217

Please let us know if you have any other issues, and sorry for the slow turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment