New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCPDF 6.2.12 => solved my issue and could solve yours #383

Open
p-drolima opened this Issue Sep 22, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@p-drolima

p-drolima commented Sep 22, 2018

I was recently encontering issues with image rendering and someone advised me to downgrade the version of TDPDF to 6.2.12 (@boileau) - I just thought of making this suggestion to others that might be encountering similar problems and give that a try.

Hope this saves you time.

@p-drolima p-drolima changed the title from TCPDF 6.2.22 => solved my issue and could solve yours to TCPDF 6.2.12 => solved my issue and could solve yours Sep 22, 2018

@spipu

This comment has been minimized.

Owner

spipu commented Sep 24, 2018

hi,
did you find the exact version of TCPDF that cause the pb ?

i see this on the last version 6.2.25 :
tecnickcom/TCPDF@a5135e2

@p-drolima

This comment has been minimized.

p-drolima commented Sep 24, 2018

yes, I tried 6.2.12 and worked for me. I havent test other versions but just know that one works at least for my use case

@p-drolima

This comment has been minimized.

p-drolima commented Sep 24, 2018

I did a pull request on it... if you like to merge

@spipu

This comment has been minimized.

Owner

spipu commented Sep 24, 2018

have you test with the 6.2.25 ? they fix the pb i think with the commit i give in my last message

@spipu

This comment has been minimized.

Owner

spipu commented Sep 24, 2018

(fixing the exact version of a dependency is a very bad practice)

@spipu spipu added the bug label Sep 24, 2018

@p-drolima

This comment has been minimized.

p-drolima commented Sep 24, 2018

I am aware of that, just more for your reference... had the feeling you would not want to merge it :)

@p-drolima

This comment has been minimized.

p-drolima commented Sep 24, 2018

I will try 6.2.25

@naitsirch

This comment has been minimized.

naitsirch commented Oct 12, 2018

Same problem here.
Image rendering worked fine with TCPDF 6.2.21. It stopped working with 6.2.22.

@naitsirch

This comment has been minimized.

naitsirch commented Oct 12, 2018

In my case even 6.2.25 does not work.

I am using inline images (data URLs) like this:

<img src="data:image/png;base64,#######">

CC: @nicolaasuni

@LittleBigFox

This comment has been minimized.

Contributor

LittleBigFox commented Oct 12, 2018

Hi!
I make the update this morning of tcpdf, all worked fine when i installed php-curl on my server, and restart apache...
If it can help you...
Regards,
LBF

@naitsirch

This comment has been minimized.

naitsirch commented Oct 12, 2018

@LittleBigFox In my case it does not help, because I am using inline images, that do not have to be downloaded from external resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment