Performance improvements #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implicit typecasts into using identity operator
… needless concatenations into single declarations
…ependency: php >= 5.3)
…reduced repeated calculation/call of identical value/method, made in_array() checks strict, merged nested positive ifs, simplified array creation
…d repeatedly indentical declared parameters in reused variable
… is_null method call by faster comparison with null, replaced intval() calls with faster (int), extracted unchanging calculations from iteration-loop, removed unnecessary parenthesis, +declared uncaught exceptions in phpDoc
|
closed PR, will open another one containing more commits right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few simple performance improvements, without any functional change to html2pdf's functionality. For details see included commits.