Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove quotes from extracted font-family #177

Closed
wants to merge 1 commit into from
Closed

Conversation

mvachette
Copy link

closes #176

I did the modification on branch 4.6 because this is the version i use. I can edit my PR to target another branch, depending of your version policy.

@spipu
Copy link
Owner

spipu commented May 17, 2017

you forget others chars, like \t, \n, ...

i think the best way is to use lines, to use the original trim default value

                    $val = trim($val[0]);
                    $val = trim($val, '\'"');

can you update your PR ?

i will add it directly on the master branch

spipu added a commit that referenced this pull request May 17, 2017
@spipu
Copy link
Owner

spipu commented May 19, 2017

i close this PR. The 4.6 branch is not deprecated

@spipu spipu closed this May 19, 2017
icebird93 pushed a commit to EduBase/html2pdf that referenced this pull request Jun 18, 2018
aaryarajojuH added a commit to aaryarajojuH/spipu that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants