New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three plugin has arbitrary 'faces' warning at 1,000 #4

Open
air opened this Issue May 12, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@air
Copy link

air commented May 12, 2014

I wondered why the three plugin has this line

https://github.com/spite/rstats/blob/master/src/rStats.extras.js#L101

Forcing a warning when your faces gets above 1,000. This must be arbitrary given you don't know how complex a scene the user will have - mine has many more.
I couldn't create the right incantation to override the value without patching the js.

Any thoughts? Thanks.

@spite

This comment has been minimized.

Copy link
Owner

spite commented May 12, 2014

Yes, absolutely. It's a very arbitrary value, it was an example of how it would work. The actual value should be several orders of magnitude higher (or none).

The only way right now is to patch the WebGL plugin. I haven't thought of a way of instantiating a plugin and passing values to the values defines. May be another JSON object that is used to override the default values would be useful?

@air

This comment has been minimized.

Copy link

air commented May 15, 2014

Perhaps an easy way would be to have two optional arguments that allow _values and _groups to be overridden. The current values would be defaults for users that don't pass them in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment