Support for App IDs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 this commit.. today is the final day OER will work without an app id. |
|
Merged thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenExchangeRates.org have indicated that all endpoints must have App IDs appended to the URL in order for the API to continue working. The switchover will be final very soon.
I've added the hooks for doing this and an initial test for complaining when app ids are not present. The tests will not run without an app id, which is freely obtainable.
I'll also updated the README, so it becomes obvious what needs to be done. I haven't had time to polish this as much as I'd like, but it's a decent first cut.