Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove directory with weird mojibake encoding #183

Merged
merged 1 commit into from
Apr 13, 2020
Merged

remove directory with weird mojibake encoding #183

merged 1 commit into from
Apr 13, 2020

Conversation

baldurmen
Copy link
Contributor

I don't know how that directory was created (and it's been there for a year already...) but suddently my Debian QA tools freaked out on this weirdly encoded thing...

oo@bar:~/git/supysonic/tests/assets$ ls -l
total 148
drwxr-xr-x 2 emiliano emiliano  4096 avr  1 22:51 ''$'\346'
-rw-r--r-- 1 emiliano emiliano    23 avr  1 22:51  23bytes
-rw-r--r-- 1 emiliano emiliano    33 avr  1 22:51  23bytes.txt
-rw-r--r-- 1 emiliano emiliano  6155 avr  1 22:51  cover.jpg
-rw-r--r-- 1 emiliano emiliano     0 avr  1 22:51  empty
drwxr-xr-x 2 emiliano emiliano  4096 avr  1 22:51  folder
drwxr-xr-x 2 emiliano emiliano  4096 avr  1 22:51  formats
-rw-r--r-- 1 emiliano emiliano  1955 avr  1 22:51  issue133.flac
-rw-r--r-- 1 emiliano emiliano  2760 avr  1 22:51  issue139.aac
-rw-r--r-- 1 emiliano emiliano 85812 avr  1 22:51  issue139.mp3
-rw-r--r-- 1 emiliano emiliano   229 avr  1 22:51  sample.ini
-rw-r--r-- 1 emiliano emiliano 24235 avr  1 22:51  subsonic-rest-api-1.9.0.xsd

Bash also showed the char as �/

@baldurmen
Copy link
Contributor Author

FWIW, the commit that created that is 270fa98

@codecov-io
Copy link

codecov-io commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #183 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   88.35%   88.29%   -0.07%     
==========================================
  Files          33       33              
  Lines        3211     3211              
==========================================
- Hits         2837     2835       -2     
- Misses        374      376       +2
Impacted Files Coverage Δ
supysonic/covers.py 83.54% <0.00%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bee277...f7ecf08. Read the comment docs.

@spl0k
Copy link
Owner

spl0k commented Apr 13, 2020

This folder is here to test that the scanner doesn't bork with badly encoded paths (even if there is no specific test for this kind of issues).
You got the wrong commit, see #85 and 954c75b

Maybe a better approach would have been to create this folder during a test rather than versioning it 🤔

@spl0k
Copy link
Owner

spl0k commented Apr 13, 2020

It seems no test tries to scan this folder anymore, and that the error on badly encoded path reappeared 😮
This will be merged and (re)fixed in a few minutes.

@spl0k spl0k merged commit f7ecf08 into spl0k:master Apr 13, 2020
@baldurmen
Copy link
Contributor Author

Ah, thanks for the follow up. Makes sense. Turns out one of our QA tool broke and this helped find a bug :)

I do think generating that directory during the tests and cleaning it afterwards makes much more sense though, as a bunch of things don't like badly encoded paths.

@pR0Ps
Copy link
Contributor

pR0Ps commented Apr 22, 2020

Thanks for merging this - it was causing me headaches when trying to develop on MacOS (Linux was fine)

anarcat added a commit to anarcat/openzfs-docs that referenced this pull request May 18, 2022
@anarcat
do *not* enforce UTF-8
afcb6c7 
i have tried to convert a real, live workstation to ZFS and had to recreate all filesystems because of this silly settings. It actually failed to copy [source code from the supysonic project](https://github.com/spl0k/supysonic/tree/270fa9883b2f2bc98f1482a68f7d9022017af50b/tests/assets/%E6) (which was [eventually removed](spl0k/supysonic#183), but still). I don't think we should suggest such an advanced setting by default and, in general, I find that this guide suggests too many exotic things, instead of focusing on "just install the thing with ZFS".
@anarcat anarcat mentioned this pull request May 18, 2022
Closed
anarcat added a commit to anarcat/openzfs-docs that referenced this pull request May 19, 2022
@anarcat
do *not* enforce UTF-8
7599f81 
I have tried to convert a real, live workstation to ZFS and had to
recreate all filesystems because of this silly settings. It actually
failed to copy [source code from the supysonic project][1] (which was
[eventually removed][2], but still).

This commit addresses *all* such incantations I could find, but keep a
reference to it in the **Hints** section or, if it's not present,
the **Notes** section, mentioning it was removed and why. This is so
people *can* still add it if they want.

 [1]: https://github.com/spl0k/supysonic/tree/270fa9883b2f2bc98f1482a68f7d9022017af50b/tests/assets/%E
 [2]: spl0k/supysonic#183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baldurmen @codecov-io @spl0k @pR0Ps