Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

bundle install won't install ffi #18

Closed
paneq opened this Issue Jun 14, 2012 · 12 comments

Comments

Projects
None yet
2 participants

paneq commented Jun 14, 2012

This probably has something to do with this hack in gemspec:

needs_ffi = true

if defined?(RUBY_ENGINE) && RUBY_ENGINE =~ /rbx/
  needs_ffi = false
  platform = Gem::Platform::new ['universal', 'rubinius', '1.2']
end

#...
 if needs_ffi
    s.add_runtime_dependency    'ffi',          '~> 1.0.0'
  end

It probably works fine when bundled from :git or using :path but I am not sure about the versions submitted to rubygems.

Owner

splattael commented Jun 15, 2012

Which ruby version do you use?

libnotify comes with 2 gems. One requires ffi the other (rubinius) doesn't.

paneq commented Jun 15, 2012

ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux]
Owner

splattael commented Jun 15, 2012

$ ruby -v
ruby 1.8.7 (2011-02-18 patchlevel 334) [x86_64-linux], MBARI 0x6770, Ruby Enterprise Edition 2011.03
$ gem install libnotify

Fetching: ffi-1.0.11.gem (100%)
Building native extensions.  This could take a while...
Fetching: libnotify-0.7.3.gem (100%)
Successfully installed ffi-1.0.11
Successfully installed libnotify-0.7.3
2 gems installed

Same for ruby 1.9.3

Owner

splattael commented Jun 15, 2012

For rbx it won't install ffi:

$ ruby -v
rubinius 1.2.4dev (1.8.7 7ae451a1 yyyy-mm-dd JI) [x86_64-unknown-linux-gnu]
$ gem install libnotify
Fetching: libnotify-0.7.3-universal-rubinius-1.2.gem (100%)
Successfully installed libnotify-0.7.3-universal-rubinius-1.2
1 gem installed

@splattael splattael closed this Jun 15, 2012

@splattael splattael reopened this Jun 15, 2012

Owner

splattael commented Jun 15, 2012

Do you have installation log for me? gem list before and after gem install libnotify?

paneq commented Jun 15, 2012

https://gist.github.com/2935486

Maybe it is a bug in bundler ? gem install works fine.

Owner

splattael commented Jun 15, 2012

Thanks for your time!

I can reproduce this failure using bundler and setup a test project for this:
https://github.com/splattael/libnotify-bundler-test

I will dig into it later today.

splattael pushed a commit that referenced this issue Jun 15, 2012

Don't build a separate gem for Rubinius anymore.
This possibly caused problems when using bundler.
See issue on GH #18
Owner

splattael commented Jun 15, 2012

I've just released 0.7.4.pre.

Could you please test it?

Gemfile:

gem 'libnotify', '0.7.4.pre'

You can remove ffi then.

Owner

splattael commented Jun 16, 2012

Any news?

paneq commented Jun 16, 2012

It works fine now. Ship it! :)

Owner

splattael commented Jun 16, 2012

Great! Done: http://rubygems.org/gems/libnotify/versions/0.7.4

Thanks for your support :)

@splattael splattael closed this Jun 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment