-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP DEBUG versions #11
Comments
No idea what z-ray is. The builds include xdebug and enable it by default. I guess it should be possible to disable xdebug through a local php.ini as described in the documentation. |
z-ray is a zend extension to php that gives you information about the request like function calls, memory consumption, db querys etc. http://www.zend.com/en/products/server/z-ray x-debug doesn't require a debug build of PHP as far as I can recall? I have added it to non debug builds of php before. As far as I recall the debug symbols of php are only needed to debug php itself, when you work on the core for instance develop your own extensions etc. |
Hmm I'm not explicitly enable any debug flags: https://github.com/splitbrain/docker-phpfarm/blob/master/phpfarm/custom-options.sh And the options set by phpfarm do not to do either: https://github.com/cweiske/phpfarm/blob/master/src/options.sh What makes you think they are compiled with debug symbols? Does phpinfo() mention it? |
Running bash on the image and checking the versions of the built php versions.
As you can see it's clearly marked as (DEBUG) |
Hmm weird. I guess we need some --no-debug build flag or something? Pull request welcome. |
No that doesn't seem to be a valid flag. The environment variable DEBUG can also make sure debug builds are built. But can't see that being set anywhere either. |
I think the PHPFarm compile script is the one that inserted the That flag seems to be hardcoded in There is another more updated fork of the PHPFarm script here https://github.com/fpoirotte/phpfarm . This allows you to disable the I might create a version of this repo using the more updated PHPFarm script if I have time, but don't hold your breath! |
That fork looks interesting. I'm looking into it right now... it does not work right out of the box as replacement, so I have to figure out what to adjust. |
I just pushed a branch that makes use of the fork. Took me a while but it seems to work now. Could you try it before I merge it into master? |
I'll check it out. I manually made it strip --enable-debug from the compile.sh script and that worked fine to. But I'll give your fork a go asap. |
Thanks @splitbrain I tried the fpoirotte branch with Dockerfile-Jessie, it seems to work fine and indicates it's NOT a debug build:
I'll try the Dockerfile-Wheezy version next. |
Hi @splitbrain I tried the fpoirotte branch with Dockerfile-Wheezy. The build took a long time 😂 but I loaded index.php for the different PHP versions and all reported NO debug build. I also tested with PHP CLI, see below. root@11d77e36344b:/phpfarm/inst/php-5.2/bin# ./php --version
PHP 5.2.17 (cli) (built: Mar 23 2017 10:16:18)
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.2.0, Copyright (c) 1998-2010 Zend Technologies
with Xdebug v2.2.7, Copyright (c) 2002-2015, by Derick Rethans I guess we're good to go? |
I noticed that the PHP versions built are DEBUG versions. I was going to use this for a local development image. So I modified it a bit. But how do I make it build RELEASE builds of PHP? I wanted to use Z-Ray with the supported versions but that doesn't work with DEBUG builds.
The text was updated successfully, but these errors were encountered: