Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honeypot, inputlabel, inputlen #80

wants to merge 1 commit into
base: master


Copy link

kp-org commented Feb 6, 2017

  • Make the honeypot invisible or not. It doesn't disable the honeypot. Configurable.
  • Show the text "Please fill ..." between the image and the input field. Configurable.
  • Limit the length of the input field of the captcha code. The limit is the same as 'lettercount' - works but is not perfect. The limit should be greater than 'lettercount', but not unlimited. Not Configurable.

This comment has been minimized.

Copy link

splitbrain commented Feb 6, 2017

It would have been better to have this in three separate pull requests...

  • I like the max-length attribute. I actually thought I had done that already.
  • I don't like the config option for the label position. I would prefer a discussion about why this change seems useful to you and then decide if we should move it after the image always.
  • I'm unsure about the honeypot visibility. Why would you want it visible?

This comment has been minimized.

Copy link

kp-org commented Feb 6, 2017

Your weighting seems to be vice versa to mine ;-). I thought the max-lenght feature is the one you don't like.

  • The label position can be decided by the user. I like it after the image.
  • honeypot: if it is visible it takes some more place only. I use the captcha mainly with the blogtng plugin. In case there is a short blog entry, the comment/captcha takes more place than the entry itself. But it is a question what you like. It is also a user decision to make it (in)visible. Btw., I use a farming too.

If you like the max-length only, please feel free to use this part only. I think splitting this pull request is more work than adding 2 lines by hand. Initially I made the changes before I used Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.