Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not use the windows shares after the update to Detritus #1302

Closed
LardVerschuren opened this issue Aug 12, 2015 · 8 comments
Closed

Can not use the windows shares after the update to Detritus #1302

LardVerschuren opened this issue Aug 12, 2015 · 8 comments

Comments

@LardVerschuren
Copy link

@LardVerschuren LardVerschuren commented Aug 12, 2015

My existing links to files via Windows shares in dokuwiki don't work after the update to Detritus. I have found that the code put too much slash by:

file:///server/test.xlsx

And that must be only two slashs such as file://server/test.xlsx.

Can somebody fix it? :-)

@Klap-in
Copy link
Collaborator

@Klap-in Klap-in commented Aug 12, 2015

Here additional slashes are trimmed: 83b7e38, since November 2014

Since 2005 the three slashes where already there:
windows shares links modified: 1d47afe
added as new code: 0cecf9d

Why has it work fine for so long time, but is it recently that people observe this behavior?

btw, What is the syntax that you used in the wiki text?

@splitbrain
Copy link
Owner

@splitbrain splitbrain commented Aug 12, 2015

Three slashes should be correct. The first two are the protocol divider. The third is the root directory.

@LardVerschuren
Copy link
Author

@LardVerschuren LardVerschuren commented Aug 13, 2015

The syntax is very simple: [[\server\data\ict\sheet.xlsx|Here is the sheet]. And it has worked for years. After the upgrade to Detritus it does not work. IE reports that the page can not found and the link in the address space is:
res://ieframe.dll/dnserror.htm#file:///server/data/ict/sheet.xlsx

If I manual adjust the url to file://server/data/ict/sheet.xlsx then it works.

Should it matter if my PHP version is 5.3.4? It should be supported, I mean.

@selfthinker
Copy link
Collaborator

@selfthinker selfthinker commented Aug 13, 2015

Windows shares haven't worked for me since a while as well. Will try to figure out if it does work for me before that change.

@Chris--S
Copy link
Collaborator

@Chris--S Chris--S commented Aug 14, 2015

@cahooa
Copy link

@cahooa cahooa commented Aug 14, 2015

We have the exact same issue, after updating to Detritus none of our windows share links work. Removing one of the slashes from the file part of the URL fixes the problem. How can I fix this?

edit: I figured it out. Followed the link to issue 1304 and then found where xhtml.php was edited to add two slashes to the file url on line 1037.

@selfthinker
Copy link
Collaborator

@selfthinker selfthinker commented Aug 17, 2015

@Klap-in, you were reading the code wrong, it has always been four slashes until 83b7e38. Read the line before... the $url always included one slash already... until it got removed by the change in #926.
@micgro42, what was the reason for that change? Was it actually breaking anything?

@selfthinker
Copy link
Collaborator

@selfthinker selfthinker commented Aug 17, 2015

Fixed by #1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.