Can not use the windows shares after the update to Detritus

[LardVerschuren]

My existing links to files via Windows shares in dokuwiki don't work after the update to Detritus. I have found that the code put too much slash by:

file:///server/test.xlsx

And that must be only two slashs such as file://server/test.xlsx.

Can somebody fix it? :-)

[Klap-in]

Here additional slashes are trimmed: 83b7e38, since November 2014

Since 2005 the three slashes where already there:
windows shares links modified: 1d47afe
added as new code: 0cecf9d

Why has it work fine for so long time, but is it recently that people observe this behavior?

btw, What is the syntax that you used in the wiki text?

[Klap-in]

Here additional slashes are trimmed: 83b7e38, since November 2014

Since 2005 the three slashes where already there:
windows shares links modified: 1d47afe
added as new code: 0cecf9d

Why has it work fine for so long time, but is it recently that people observe this behavior?

btw, What is the syntax that you used in the wiki text?

[splitbrain]

Three slashes should be correct. The first two are the protocol divider. The third is the root directory.

[splitbrain]

Three slashes should be correct. The first two are the protocol divider. The third is the root directory.

[LardVerschuren]

The syntax is very simple: [[\server\data\ict\sheet.xlsx|Here is the sheet]. And it has worked for years. After the upgrade to Detritus it does not work. IE reports that the page can not found and the link in the address space is:
res://ieframe.dll/dnserror.htm#file:///server/data/ict/sheet.xlsx

If I manual adjust the url to file://server/data/ict/sheet.xlsx then it works.

Should it matter if my PHP version is 5.3.4? It should be supported, I mean.

[LardVerschuren]

The syntax is very simple: [[\server\data\ict\sheet.xlsx|Here is the sheet]. And it has worked for years. After the upgrade to Detritus it does not work. IE reports that the page can not found and the link in the address space is:
res://ieframe.dll/dnserror.htm#file:///server/data/ict/sheet.xlsx

If I manual adjust the url to file://server/data/ict/sheet.xlsx then it works.

Should it matter if my PHP version is 5.3.4? It should be supported, I mean.

[selfthinker]

Windows shares haven't worked for me since a while as well. Will try to figure out if it does work for me before that change.

[selfthinker]

Windows shares haven't worked for me since a while as well. Will try to figure out if it does work for me before that change.

[Chris--S]

According to this two slashes is correct, http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx

[Chris--S]

According to this two slashes is correct, http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx

[cahooa]

We have the exact same issue, after updating to Detritus none of our windows share links work. Removing one of the slashes from the file part of the URL fixes the problem. How can I fix this?

edit: I figured it out. Followed the link to issue 1304 and then found where xhtml.php was edited to add two slashes to the file url on line 1037.

[cahooa]

We have the exact same issue, after updating to Detritus none of our windows share links work. Removing one of the slashes from the file part of the URL fixes the problem. How can I fix this?

edit: I figured it out. Followed the link to issue 1304 and then found where xhtml.php was edited to add two slashes to the file url on line 1037.

[selfthinker]

@Klap-in, you were reading the code wrong, it has always been four slashes until 83b7e38. Read the line before... the $url always included one slash already... until it got removed by the change in #926.
@micgro42, what was the reason for that change? Was it actually breaking anything?

[selfthinker]

@Klap-in, you were reading the code wrong, it has always been four slashes until 83b7e38. Read the line before... the $url always included one slash already... until it got removed by the change in #926.
@micgro42, what was the reason for that change? Was it actually breaking anything?

[selfthinker]

Fixed by #1309

[selfthinker]

Fixed by #1309