Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interwiki substitution does not work for image embedding #1614

Closed
dmak opened this issue Jun 26, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@dmak
Copy link
Contributor

commented Jun 26, 2016

Provided that the following is in conf/interwiki.conf (that is the default setting)

phpfn     https://secure.php.net/{NAME}

the following

{{https://secure.php.net/images/to-top@2x.png?30|try one}}
{{phpfn>images/to-top@2x.png?30|try two}}

Once the "alias" works for page URLs, I would expect it works also for resource URLs.

@splitbrain splitbrain added the Feature label Oct 19, 2016

@splitbrain

This comment has been minimized.

Copy link
Owner

commented Oct 19, 2016

Interwiki links are not implemented for resources. PRs welcome.

@dmak

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2016

I have completed the PR with solution.
@splitbrain could you please review it?

splitbrain added a commit that referenced this issue Nov 13, 2016

Merge pull request #1737 from dmak/issue-1614
Implemented interwiki substitution for external images (issue #1614).
@salsa-dev

This comment has been minimized.

Copy link

commented Nov 30, 2016

Thank you very much for this PR! I was just about to submit the same issue.

I'm using interwiki links to link to data on IPFS running locally.

splitbrain added a commit that referenced this issue Nov 30, 2016

Merge branch 'master' into extensionevent
* master: (62 commits)
  authpdo - use type safe comparison on passwords. fixes #1765
  removed unneeded files from random_compat
  Use cryptographically secure pseudo random number generator (CSPRNG)
  translation update
  translation update
  translation update
  translation update
  translation update
  or maybe I only now figured out the right travis config :-/
  disable 7.1 testing completely
  allow 7.1 failures until it's released #1682
  DE translation for key 'protected'
  Use 'Benachrichtigung' instead of 'Notifikation'
  Fix spelling of some terms (lower to upper case)
  DE translation for key: addUser_error_missing_pass
  DE translation for keys: update_name, update_mail
  translation update
  translation update
  Implemented interwiki substitution for external images (issue #1614).
  translation update
  ...

splitbrain added a commit that referenced this issue Nov 30, 2016

Merge branch 'master' into phpseclib
* master: (54 commits)
  updated geshi
  authpdo - use type safe comparison on passwords. fixes #1765
  removed unneeded files from random_compat
  Use cryptographically secure pseudo random number generator (CSPRNG)
  translation update
  translation update
  translation update
  translation update
  translation update
  or maybe I only now figured out the right travis config :-/
  disable 7.1 testing completely
  allow 7.1 failures until it's released #1682
  DE translation for key 'protected'
  Use 'Benachrichtigung' instead of 'Notifikation'
  Fix spelling of some terms (lower to upper case)
  DE translation for key: addUser_error_missing_pass
  DE translation for keys: update_name, update_mail
  translation update
  translation update
  Implemented interwiki substitution for external images (issue #1614).
  ...

@splitbrain splitbrain closed this Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.