Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Please remove unintended google search #2588
When /inc/parser/renderer.php meets a link with an "unknown" protocol, such as "file://", clicking that link sends the contents of the link to Google search WHICH WAS OBVIOUSLY NOT INTENDED BY THE USERS and can disclose personal information.
Please remove this feature.
Good observation. Some clarification:
The link in this situation (
I wonder where is better for us to direct users to in this situation? Maybe the first item in
While I'm not convinced that the fallback Google "I'm Feeling Lucky" behaviour presents much of a risk for most users, I don't see that it adds much value either. Given that, and given that it is possible to imagine a scenario where this might present a risk to a user connecting to the Internet via a proxy controlled by e.g. an authoritarian government, I agree that it should be removed.
As for how to handle undefined interwiki types, my suggestion is to create no link at all, and add a warning message:
The current Google behaviour could be retained as a config option for anyone who wanted to keep doing that. I'm struggling to imagine when the current behaviour is ever what people want though.
I'm willing to code my proposal, if there is consensus that it's a worthwhile thing to do.