Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning messages with PHP 7.3 #2622

Closed
yasuhirokimura opened this issue Dec 7, 2018 · 5 comments
Closed

Warning messages with PHP 7.3 #2622

yasuhirokimura opened this issue Dec 7, 2018 · 5 comments

Comments

@yasuhirokimura
Copy link

@yasuhirokimura yasuhirokimura commented Dec 7, 2018

OS: FreeBSD 11.2-RELEASE
PHP: 7.2.12 -> 7.3.0 (Installed using FreeBSD port)
DokuWiki: 20180422a (Installed using FreeBSD port)

After update PHP to 7.3, following messages are displayed on the top of page.

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/dokuwiki/inc/parser/handler.php on line 1552

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/dokuwiki/inc/parser/handler.php:1552) in /usr/local/www/dokuwiki/inc/actions.php on line 38

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/dokuwiki/inc/parser/handler.php:1552) in /usr/local/www/dokuwiki/lib/tpl/dokuwiki/main.php on line 12

They are disappeared when accessing same page. But displayed again if I clear files and directories under $conf['savedir']/cache.

@onkobu
Copy link

@onkobu onkobu commented Dec 11, 2018

This also breaks JavaScript. jquery.php starts with: <br />
<b>Warning</b>: …

@splitbrain
Copy link
Owner

@splitbrain splitbrain commented Dec 12, 2018

This has been fixed in 296be24

@bug this is a simple one-line fix. Should we release a hotfix for PHP 7.3 compability?

@michitux
Copy link
Collaborator

@michitux michitux commented Dec 12, 2018

@splitbrain @bug Could you then also include #2609 in the hotfix release?

@phy25
Copy link
Collaborator

@phy25 phy25 commented Jan 8, 2019

Closing because of the release of 2018-04-22b.

@phy25 phy25 closed this Jan 8, 2019
@onkobu
Copy link

@onkobu onkobu commented Mar 15, 2019

Works perfectly, thanks a lot.

bob-beck pushed a commit to openbsd/ports that referenced this issue Jun 9, 2020
Hotfix 2018-04-22b
fix PHP 7.3 compatibility: splitbrain/dokuwiki#2622
fix ACL check: splitbrain/dokuwiki#2609
Hotfix 2018-04-22c
fix an XSS Vulnerability: splitbrain/dokuwiki#3044

ok pea@ (MAINTAINER) rsadowski@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants