Introduction of a media white list. #195

Closed
wants to merge 14 commits into
from

Conversation

Projects
None yet
3 participants

This patch adds the ability to configure a white list of media files, which can be useful to explicitly allow certain files to be uploaded. It overrides the file 'mime.conf'. I use this to whitelist files like 'vimrc' (files without extension), which normally would not be possible with the normal 'mime.conf' mechanism.

Owner

splitbrain commented Jun 2, 2013

First of all this PR includes two things: one is introducing case sensitive page names, the other is the mentioned media white list. Both should be separate PRs.

The case sensitivity will break cross platform compatibility when moving an install between systems. So that's a no go.

I'm also not a big fan of the media whitelist thing. It complicates things, for a somewhat rare use case. It might be possible to implement this in a plugin though.

I vote for not merging.

First of all this PR includes two things: one is introducing case sensitive page names,
the other is the mentioned media white list. Both should be separate PRs.

Yes, this is clearly my fault. Must have happened when I rebased the branches
to a more recent master. The original intention was to have two separate PRs.

The case sensitivity will break cross platform compatibility when moving an install
between systems. So that's a no go.

This was also your statement in the past, but it was not my intention to include
it into the PR, only the mediawhitelist.

Besides, IMHO, it could be an option for advanced users who do like case sensitivity
but have no need for cross-platform.

I'm also not a big fan of the media whitelist thing. It complicates things, for a somewhat
rare use case. It might be possible to implement this in a plugin though.

I use it for 'Makefile' or 'vimrc' type of files, which have no extension
and therefore are not recognized as a valid MIME type. Especially interesting for developer
centered Wikis.

I vote for not merging.

If the mediawhitelist anlone would be of interest, I could untangle it from the case
sensitivity stuff, not a big effort.

If not, no problem.


(github seems not to display blockquotes correctly if sent by email reply)

Collaborator

Chris--S commented Jun 2, 2013

do downloadable code blocks work for you?

Owner

splitbrain commented Jun 2, 2013

You can always upload your files with a .txt extension or use downloadable code blocks (much cooler for stuff like vimrc or Makefile anyway). Won't merge.

@splitbrain splitbrain closed this Jun 2, 2013

Downloadable code blocks are nice, but not the answer to everything. Thanks on looking into the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment