Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .htaccess files for Apache 2.4 (and 2.2) #2429

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@xela74
Copy link
Contributor

xela74 commented Jun 17, 2018

Refer to module by suitable file name (mod_*.c).
Test for mod_authz_core.c (instead of mod_authz_host.c) to properly
detect Apache 2.4 and avoid false positive for Apache 2.2.

Closes #2428.

Fix .htaccess files for Apache 2.4 (and 2.2)
Refer to module by suitable file name (mod_*.c).
Test for mod_authz_core.c (instead of mod_authz_host.c) to properly
detect Apache 2.4 and avoid false positive for Apache 2.2.
@jobhh

This comment has been minimized.

Copy link

jobhh commented Jun 19, 2018

Although functional, this is still a hack. Is there a reason why we're not using the Apache module mod_version? It was included in all distributions I've used the past 10(?) years. Are there known cases where it isn't included?

It immediately makes it clear what the if statement does:

<IfVersion >= 2.4>
    Require all denied
</IfVersion>
<IfVersion < 2.4>
    Order allow,deny
    Deny from all
</IfVersion>

Edit: Just realised I might have better posted this in the accompanying issue. I'll post my question there ;)

@splitbrain splitbrain merged commit cbaf278 into splitbrain:master Jun 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.