Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change `const` use to `var` for Safari 9 (on iOS) #2430

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@bwanders
Copy link
Contributor

bwanders commented Jun 19, 2018

Safari 9 in iOS does not support the use of const in strict mode. Unfortunately, some of us are stuck with Safari 9 due to not being able to upgrade.

I am a big fan of progressive enhancement, but because all javascript code is packed together and sent off to the client, this small incompatibility breaks all javascript for safari 9 browsers. Switching these two keywords makes everything work again.

There are no other uses of const in the codebase as far as I can find. This change has little to no impact on anything else, but slighlty extends the range of supported browsers.

(I could not find a specific listing of supported browsers on https://www.dokuwiki.org/browser. While I agree that Safari 9 is not exactly "an up-to-date version", it seems to me that this was an accidental incompatibility.)

Change `const` use to `var` for Safari 9 (on iOS)
Safari 9 in iOS does not support the use of `const` in strict mode. Unfortunately, some of us are stuck with Safari 9 due to not being able to upgrade.

I am a big fan of progressive enhancement, but because all javascript code is packed together and sent off to the client, this small incompatibility breaks all javascript for safari 9 browsers. Switching these two keywords makes everything work again.

There are no other uses of `const` in the codebase as far as I can find. This change has little to no impact on anything else, but slighlty extends the range of supported browsers.

@splitbrain splitbrain merged commit 2ead9e5 into splitbrain:master Jun 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bwanders bwanders deleted the bwanders:patch-1 branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.