Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link rendering for external links at start of line #2433

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@LarsGit223
Copy link
Collaborator

LarsGit223 commented Jun 21, 2018

External links at the start of line like www.example.com were not rendered as links any more. The issue was introduced with PR #1988. Fixes #2399.

@Chris--S

This comment has been minimized.

Copy link
Collaborator

Chris--S commented Jun 21, 2018

Only comment, are we sure that '/' is the only character that disallows simple urls? Off the top of my head, no testing, paths with '\' ?

Other than that, 👍

@splitbrain

This comment has been minimized.

Copy link
Owner

splitbrain commented Jun 26, 2018

@LarsGit223 you tagged this with needs improvement. Can you explain what needs to be done here?

@LarsGit223

This comment has been minimized.

Copy link
Collaborator Author

LarsGit223 commented Jun 26, 2018

@splitbrain: @ssahara suggested an adjustment of the pattern, see end of the discussion at #2399

I wanted to apply that change and eventually add more test cases (if missing, e.g. for a link in round parenthesis)

Fixed broken link rendering for external links at start of line
External links at the start of line like 'www.example.com' were
not rendered as links any more. The issue was introduced with PR #1988.
Fixes #2399.

@LarsGit223 LarsGit223 force-pushed the issue2399 branch from 36d2cd7 to 382559b Jun 26, 2018

@LarsGit223

This comment has been minimized.

Copy link
Collaborator Author

LarsGit223 commented Jun 26, 2018

@splitbrain: looks ok to me now. Travis CI build failures are not caused by my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.