New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create page from search in NS with ACL #2513

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@peterfromearth
Contributor

peterfromearth commented Sep 22, 2018

as described in #2507 it is not possible for acl restricted users to create pages in namespaces from the search.
The pagename for auth_quickaclcheck has a left colon. After removing it, it works as expected.

@phy25

phy25 approved these changes Oct 12, 2018

Thanks for your contribution! I think we need to merge this as a bugfix, because auth_aclcheck() needs "a resolved and cleaned page ID", and prefixing : is not cleaned. The current code of the acl check is not working correctly towards namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment