New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notice that ip is publicly displayed for anonymous edits #2523

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@flammy
Contributor

flammy commented Oct 9, 2018

Feature:
This PR refers to #2320 and adds a notification of type security, if a anonymous users edits a page.
screenshot

Changes:
This PR modifies the behaviour of displaying paragraphs in message boxes:

  • removed margin from paragraphs inside of message boxes

Additions:
This PR creates a new type of message boxes:

  • security

The commit e3f29c7 contains the changes, other commits are master merges.

flammy and others added some commits Oct 9, 2018

Merge pull request #1 from splitbrain/master
Update from Upstream
@@ -0,0 +1,3 @@
You are not logged in. Your IP address will be publicly visible if you make any edits.
If you log in, your edits will be attributed to a user name.

This comment has been minimized.

@micgro42

micgro42 Oct 9, 2018

Collaborator

It should probably be "[...] will be attributed to your username."?

@Michaelsy

This comment has been minimized.

Michaelsy commented Oct 9, 2018

IMHO this PR alone does not solve the issue. The IP address will be saved in the history even if you are logged in. (Unlike Wikipedia) As far as I can see, this IP address is displayed for each superuser/admin and for each manager. This is not completely public, but I think if we give the impression that the IP address is not being recorded, we should implement it this way.

Just my 2 cents - Michael Sy.

Lukas Rademacher
@splitbrain

This comment has been minimized.

Owner

splitbrain commented Oct 9, 2018

I don't think I would want to introduce a completely new message type for this. There's is no reason to use the message system for this at all. The message could simply be part of the edit view.

@flammy

This comment has been minimized.

Contributor

flammy commented Oct 9, 2018

@splitbrain you are right, maybe its some kind of overkill to introduce a new type.

But there are 2 reasons I choose the message system for displaying:

  • It is highlighted:
    • In the edit view is already a message displayed, so nobody will notice if the text of it changes
    • It should be visible and highlighted to fulfil GDPR
  • It is already there:
    • The message boxes are known to the users
    • No messing around with creating new HTML and CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment