Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery Update and jQuery Migrate removal #3066

Merged
merged 2 commits into from May 4, 2020
Merged

jQuery Update and jQuery Migrate removal #3066

merged 2 commits into from May 4, 2020

Conversation

splitbrain
Copy link
Collaborator

@splitbrain splitbrain commented May 1, 2020

Update jQuery to 3.5.0 and Migrate removed. Closes #1546.

@phy25
Copy link
Collaborator

phy25 commented May 2, 2020

Do we still want to ship jQuery migrate (see #1546)? Specifically I have created the plugin jquerymigrate: #1546 (comment)

@splitbrain splitbrain changed the title jQuery Update and debugging option for jQuery migrate jQuery Update and jQuery removal May 2, 2020
@splitbrain
Copy link
Collaborator Author

You're right. I totally forgot about that. I updated this PR to remove jQuery Migrate. #3065 should be merged before merging this.

@phy25 phy25 changed the title jQuery Update and jQuery removal jQuery Update and jQuery Migrate removal May 2, 2020
Copy link
Collaborator

@phy25 phy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I just realised and would like to note: jQuery UI hasn't been updated for years. I remember that I have seen some warnings from jquery-migrate about jQuery UI code (but they should work fine together as of jQuery 3.x). We might need to deprecate that sometime as well.

@splitbrain splitbrain merged commit a131d86 into master May 4, 2020
@splitbrain splitbrain deleted the jquery-update branch May 4, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove jquery-migrate
2 participants