Skip to content

Test enhancement #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 5, 2018
Merged

Test enhancement #23

merged 15 commits into from
Feb 5, 2018

Conversation

@peter279k
Copy link
Contributor

@peter279k peter279k commented Feb 4, 2018

Changed log

  • set the correct Travis settings
  • improve the tests
  • using vfsStream to mock the file system for outputing the archive file.
    It's recommended by official PHPUnit doc.

@splitbrain
Copy link
Owner

splitbrain commented Feb 5, 2018

Great! I'll merge this right away.

One minor thing: shouldn't RDelete() be rDelete()?

@splitbrain splitbrain merged commit 0443bcf into splitbrain:master Feb 5, 2018
@peter279k
Copy link
Contributor Author

peter279k commented Feb 5, 2018 •
edited
Loading

Yes, you're right. It should be rDelete, not RDelete.
Thank you for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peter279k @splitbrain