Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch coverage to tests, fix clean_test.sh #52

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@milesrichardson
Copy link
Contributor

milesrichardson commented Apr 2, 2019

馃敡

Hello

Changes in this PR:

- Collect and report branch coverage when running tests, whether from
  within docker container (where tests are configured with pytest.dev.ini),
  or on the host (where tests are configured with setup.cfg)
- Fix bug in entrypoint of sgr dev container where pycache files were cleaned
  only after installing sgr, when they should be cleaned before (and might as
  well be cleaned after, too, so as not to cause the same problem when
  importing later from the host). Point is, with bind mounting, we don't
  know at any given time where the pycache (+ .pyc) files came from -- the
  host or the container -- so they could be wrong at any given time, and
  thus we err on the side of caution by clearing them aggressively.
- Add down -v directive to clean_test.sh to make sure tests all start from
  fresh volumes (e.g. fix problem where existing volume was created with pg10
  and new engine is pg11 complaining about incompatible format)

Thank you

Add branch coverage to tests, fix clean_test.sh
- Collect and report branch coverage when running tests, whether from
  within docker container (where tests are configured with pytest.dev.ini),
  or on the host (where tests are configured with setup.cfg)
- Fix bug in entrypoint of sgr dev container where pycache files were cleaned
  only after installing sgr, when they should be cleaned before (and might as
  well be cleaned after, too, so as not to cause the same problem when
  importing later from the host). Point is, with bind mounting, we don't
  know at any given time where the pycache (+ .pyc) files came from -- the
  host or the container -- so they could be wrong at any given time, and
  thus we err on the side of caution by clearing them aggressively.
- Add down -v directive to clean_test.sh to make sure tests all start from
  fresh volumes (e.g. fix problem where existing volume was created with pg10
  and new engine is pg11 complaining about incompatible format)

@milesrichardson milesrichardson requested a review from mildbyte Apr 2, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage decreased (-1.2%) to 94.766% when pulling ad5701a on bugfix/various-fixes into 43c273e on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage decreased (-1.2%) to 94.766% when pulling 2469330 on bugfix/various-fixes into 43c273e on master.

@milesrichardson milesrichardson merged commit 4be78a1 into master Apr 2, 2019

2 of 3 checks passed

coverage/coveralls Coverage decreased (-1.2%) to 94.766%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@milesrichardson milesrichardson deleted the bugfix/various-fixes branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.