From 19b30422be26717ad24076c8fe1d10eec9c30aed Mon Sep 17 00:00:00 2001 From: Emiliano Sanchez Date: Wed, 8 Oct 2025 12:29:41 -0300 Subject: [PATCH] Use log level when logger is set --- CHANGES.txt | 3 +++ package-lock.json | 18 +++++++++--------- package.json | 4 ++-- src/__tests__/offline/node.spec.js | 10 +++++++--- src/settings/defaults/version.js | 2 +- 5 files changed, 22 insertions(+), 15 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 61cd21f1c..ea434f8fc 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,3 +1,6 @@ +11.7.1 (October 8, 2025) + - Bugfix - Updated @splitsoftware/splitio-commons package to version 2.7.1, which fixes the `debug` option to support log levels when the `logger` option is used. + 11.7.0 (October 7, 2025) - Added support for custom loggers: added `logger` configuration option and `factory.Logger.setLogger` method to allow the SDK to use a custom logger. - Updated @splitsoftware/splitio-commons package to version 2.7.0. diff --git a/package-lock.json b/package-lock.json index 23598221e..2cc7b9b9a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,15 +1,15 @@ { "name": "@splitsoftware/splitio", - "version": "11.7.0", + "version": "11.7.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@splitsoftware/splitio", - "version": "11.7.0", + "version": "11.7.1", "license": "Apache-2.0", "dependencies": { - "@splitsoftware/splitio-commons": "2.7.0", + "@splitsoftware/splitio-commons": "2.7.1", "bloom-filters": "^3.0.4", "ioredis": "^4.28.0", "js-yaml": "^3.13.1", @@ -351,9 +351,9 @@ "dev": true }, "node_modules/@splitsoftware/splitio-commons": { - "version": "2.7.0", - "resolved": "https://registry.npmjs.org/@splitsoftware/splitio-commons/-/splitio-commons-2.7.0.tgz", - "integrity": "sha512-w2aemu5HNVQXX/tbmSuFjpWa/AjS+EBiH6ltHMqfg2MZMWayTFJbfjjQcudAVLR+vLjDw2DuCTp/xj3kKlcf5g==", + "version": "2.7.1", + "resolved": "https://registry.npmjs.org/@splitsoftware/splitio-commons/-/splitio-commons-2.7.1.tgz", + "integrity": "sha512-7a4VVMczh0YKVRi35EhD0FOAEwzqfJRcCiKqLLhZCxAvrZBpE2khpGn8pOP+y6TefdPVtblW8GIku4O4r0KRdQ==", "license": "Apache-2.0", "dependencies": { "@types/ioredis": "^4.28.0", @@ -7740,9 +7740,9 @@ "dev": true }, "@splitsoftware/splitio-commons": { - "version": "2.7.0", - "resolved": "https://registry.npmjs.org/@splitsoftware/splitio-commons/-/splitio-commons-2.7.0.tgz", - "integrity": "sha512-w2aemu5HNVQXX/tbmSuFjpWa/AjS+EBiH6ltHMqfg2MZMWayTFJbfjjQcudAVLR+vLjDw2DuCTp/xj3kKlcf5g==", + "version": "2.7.1", + "resolved": "https://registry.npmjs.org/@splitsoftware/splitio-commons/-/splitio-commons-2.7.1.tgz", + "integrity": "sha512-7a4VVMczh0YKVRi35EhD0FOAEwzqfJRcCiKqLLhZCxAvrZBpE2khpGn8pOP+y6TefdPVtblW8GIku4O4r0KRdQ==", "requires": { "@types/ioredis": "^4.28.0", "tslib": "^2.3.1" diff --git a/package.json b/package.json index 8a88d9769..ea3ad14b7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@splitsoftware/splitio", - "version": "11.7.0", + "version": "11.7.1", "description": "Split SDK", "files": [ "README.md", @@ -38,7 +38,7 @@ "node": ">=14.0.0" }, "dependencies": { - "@splitsoftware/splitio-commons": "2.7.0", + "@splitsoftware/splitio-commons": "2.7.1", "bloom-filters": "^3.0.4", "ioredis": "^4.28.0", "js-yaml": "^3.13.1", diff --git a/src/__tests__/offline/node.spec.js b/src/__tests__/offline/node.spec.js index 48e9fd010..afbb495e0 100644 --- a/src/__tests__/offline/node.spec.js +++ b/src/__tests__/offline/node.spec.js @@ -77,7 +77,11 @@ tape('Node.js Offline Mode', function (t) { const factory = SplitFactory({ ...config, - debug: 'ERROR', // enable logs to check the message. If logger is provided, any log level different than 'NONE' will be overridden to 'DEBUG'. + core: { + ...config.core, + key: 'ignored' // just set to log a warning + }, + debug: 'INFO', // enable logs to check the message. logger: console // use console as custom logger. }); const client = factory.client(); @@ -92,9 +96,9 @@ tape('Node.js Offline Mode', function (t) { assert.pass('If tried to load a file with invalid extension, we should emit SDK_READY_TIMED_OUT.'); assert.ok(console.error.calledWithMatch(`splitio => sync:offline: There was an issue loading the mock feature flags data. No changes will be applied to the current cache. Error: Invalid extension specified for feature flags mock file. Accepted extensions are ".yml" and ".yaml". Your specified file is ${config.features}`)); - assert.notOk(console.warn.called, 'warn should not be called'); + assert.ok(console.warn.calledWithMatch('splitio => Provided `key` is ignored in server-side SDK.')); assert.ok(console.info.called, 'info should be called'); - assert.ok(console.debug.called, 'debug should be called'); + assert.notOk(console.debug.called, 'debug should not be called'); console.error.restore(); console.warn.restore(); diff --git a/src/settings/defaults/version.js b/src/settings/defaults/version.js index d51e26fdc..2a4a3206c 100644 --- a/src/settings/defaults/version.js +++ b/src/settings/defaults/version.js @@ -1 +1 @@ -export const packageVersion = '11.7.0'; +export const packageVersion = '11.7.1';