diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 71932840..6d9b5114 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: - 6379:6379 strategy: matrix: - version: ['7.3', '8.0', '8.1'] + version: ['7.3', '8.0', '8.1', '8.2'] steps: - name: Checkout code uses: actions/checkout@v2 diff --git a/CHANGES.txt b/CHANGES.txt index 70908803..9f75675d 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,3 +1,6 @@ +7.1.6 (Feb 14, 2023) + - Fixed logging on array conversion. + 7.1.5 (Oct 28, 2022) - Updated phpdocs for `ClientInterface`. diff --git a/src/SplitIO/Component/Log/Logger.php b/src/SplitIO/Component/Log/Logger.php index 25c747cc..d05dddb1 100644 --- a/src/SplitIO/Component/Log/Logger.php +++ b/src/SplitIO/Component/Log/Logger.php @@ -60,6 +60,9 @@ public function __construct(LogHandlerInterface $handler = null, $level = LogLev public function log($level, $message, array $context = array()) { if ($this->logLevels[$level] <= $this->logLevel) { + if (is_array($message)) { + $message = json_encode($message); + } $this->handler->write($level, $message); } } diff --git a/src/SplitIO/Sdk/Client.php b/src/SplitIO/Sdk/Client.php index 921123e1..88b27b87 100644 --- a/src/SplitIO/Sdk/Client.php +++ b/src/SplitIO/Sdk/Client.php @@ -19,6 +19,7 @@ class Client implements ClientInterface private $evaluator = null; private $impressionListener = null; + private $queueMetadata = null; /** * Flag to get Impression's labels feature enabled diff --git a/src/SplitIO/TreatmentImpression.php b/src/SplitIO/TreatmentImpression.php index bb4743e0..f7ff2b14 100644 --- a/src/SplitIO/TreatmentImpression.php +++ b/src/SplitIO/TreatmentImpression.php @@ -15,8 +15,8 @@ class TreatmentImpression public static function log($impressions, QueueMetadataMessage $metadata) { try { - Di::getLogger()->debug($impressions); if (is_null($impressions) || (is_array($impressions) && 0 == count($impressions))) { + Di::getLogger()->debug("no impressions were sent"); return null; } $impressionCache = new ImpressionCache(); diff --git a/src/SplitIO/Version.php b/src/SplitIO/Version.php index bffb80b6..b827e7d0 100644 --- a/src/SplitIO/Version.php +++ b/src/SplitIO/Version.php @@ -3,5 +3,5 @@ class Version { - const CURRENT = '7.1.5'; + const CURRENT = '7.1.6'; } diff --git a/tests/Suite/Sdk/SdkReadOnlyTest.php b/tests/Suite/Sdk/SdkReadOnlyTest.php index 4eecef8a..732635c1 100644 --- a/tests/Suite/Sdk/SdkReadOnlyTest.php +++ b/tests/Suite/Sdk/SdkReadOnlyTest.php @@ -90,7 +90,7 @@ public function testException() ->getMock(); // Discard (ignore) first logging statement - $logger->expects($this->exactly(2)) + $logger->expects($this->exactly(1)) ->method('debug'); $logger->expects($this->exactly(2))