Skip to content

PHP 7.1.7 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 16, 2023
Merged

PHP 7.1.7 #205

merged 17 commits into from
May 16, 2023

Conversation

@mmelograno
Copy link
Contributor

@mmelograno mmelograno commented May 12, 2023

PHP SDK

What did you accomplish?

  • Updated terminology on the SDKs codebase to be more aligned with current standard without causing a breaking change. The core change is the term split for feature flag on things like logs and phpdoc comments.
  • Fixed php 8.2 warnings in code.

How do we test the changes introduced in this PR?

Extra Notes

@mmelograno mmelograno changed the title Dw PHP 7.1.7 May 12, 2023
@sonarqube-pull-requests
Copy link

sonarqube-pull-requests bot commented May 16, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@mmelograno mmelograno merged commit cd9133b into master May 16, 2023
@mmelograno mmelograno deleted the dw branch May 16, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmelograno @sanzmauro