Skip to content

Ensure request is defined before calling methods on it #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2013
Merged

Ensure request is defined before calling methods on it #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/split/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,14 @@ def old_versions(experiment)
end

def is_robot?
request.user_agent =~ Split.configuration.robot_regex
defined?(request) && request.user_agent =~ Split.configuration.robot_regex
end

def is_ignored_ip_address?
return false if Split.configuration.ignore_ip_addresses.empty?

Split.configuration.ignore_ip_addresses.each do |ip|
return true if request.ip == ip || (ip.class == Regexp && request.ip =~ ip)
return true if defined?(request) && (request.ip == ip || (ip.class == Regexp && request.ip =~ ip))
end
false
end
Expand Down