Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Extract ExperimentStore #225

Merged
merged 1 commit into from Dec 5, 2013

Conversation

Projects
None yet
2 participants
@nberger
Copy link
Contributor

commented Dec 5, 2013

Extracts the responsibility of finding experiments to another class

@nberger

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2013

If the idea looks good, I can add some tests for ExperimentStore.

Refactoring: Extract ExperimientStore
Extracts the responsibility of finding experiments to another class
@andrew

This comment has been minimized.

Copy link
Member

commented Dec 5, 2013

Yeah this looks good, I've started working on a similar thing before (https://github.com/andrew/split/tree/db-adapters) but never finished it.

More tests are always welcome too.

andrew added a commit that referenced this pull request Dec 5, 2013

Merge pull request #225 from nberger/refactor-experiment-save
Refactoring: Extract ExperimentStore

@andrew andrew merged commit 6fa09d1 into splitrb:master Dec 5, 2013

1 check passed

default The Travis CI build passed
Details
@nberger

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2013

Ok, I'll add some tests in a further PR.

@nberger nberger deleted the nberger:refactor-experiment-save branch Sep 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.